[mc] [mc-devel] Soft wrappings of long lines in mcedit

[Sebastian Gniazdowski]

On Mon, 21 Aug 2023 at 04:12, Yury V. Zaytsev <yury at shurup.com> wrote:
>
> On Mon, 21 Aug 2023, Jacek Pliszka wrote:
>
> > pon., 21 sie 2023 o 10:31 Sebastian Gniazdowski via mc-devel
> > <mc-devel at lists.midnight-commander.org> napisał(a):
> >
> >> able to deliver anything that I promise publicly. Please, stop
> >> spreading FUD and think about MC's project good instead.
> >
> > I think Yuri is right and for the good of the project your patch
> > should not be there.
> >
> > I believe the feature is of low value and if the complexity is half of
> > what you claim - it is not worth it.
>
> Let my try to get my point across in a different way: I definitively do
> NOT object adding soft-wraps to the editor.
>
>
> This is however a very complex feature to implement in a correct
> (including the whole Unicode / CJK story)

Yes, I've had Unicode in mind and used the next/prev/char-width
functions of mc's Unicode engine.

bug-free and performant way. We

>
> In as far as Sebastian is concerned, you don't have to take my word for
> it, just have a look at the patches and exchanges on mc's Trac, his
> nickname there is psprint.

Yes, feel free to see my patches, especially:
- https://midnight-commander.org/ticket/4174
- https://midnight-commander.org/ticket/4165
- https://midnight-commander.org/ticket/4135
- https://midnight-commander.org/ticket/4220
- https://midnight-commander.org/ticket/4187

And also my merged patches:
- https://midnight-commander.org/ticket/4160
- https://midnight-commander.org/ticket/4171
- https://midnight-commander.org/ticket/4173
- https://midnight-commander.org/ticket/4203
- https://midnight-commander.org/ticket/4207

> He is very productive, I give him that, but the code I've seen so far
> makes the blood freeze in the veins and the eyes bleed out.

I strongly disagree… What could make your "eyes bleed out", lack of
(ptr == NULL) comparison's for pointers? Or int q=Q() initializers?
Because that are the kind of objections to my code.

> Unfortunately, the likelihood that he changes his behavior seems to be
> vanishing, and we simply don't want to deal with him under the
> circumstances.

I've was in an adaptable state when I've submitted soft-wraps. You can
see it on https://midnight-commander.org/ticket/1447. I know what to
expect from you so I've adapted.

But good that you at least don't say something like "oh, well, mcedit
doesn't need line wrapping". Because EVEN nano has it:
https://asciinema.org/a/DEjBrk0TwJzRufEm98WSyz8L7


--
Best regards,
Sebastian Gniazdowski