[Fwd: [Pkg-mc-devel] Bug#607077: iso9660 extfs not recognizing joliet extension (short file names)]

[Yury V. Zaytsev]

Sounds like a trivial patch?

Can we can it committed?
 
-- 
Sincerely yours,
Yury V. Zaytsev

-------- Forwarded Message --------
From: Vaclav Ovsik <vaclav.ovsik at gmail.com>
Subject: [Pkg-mc-devel] Bug#607077: iso9660 extfs not recognizing joliet
extension (short file names)
Date: Tue, 14 Dec 2010 15:49:37 +0100

Package: mc
Version: 3:4.7.0.9-1
Severity: minor
Tags: patch

Hi,
I noticed that mc lists content of iso file (SystemRescueCD) (Joliet but no RR)
without Joliet ext. MC from Lenny behaves correctly and lists long names from
Joliet. I found a problem in the mc shell script /usr/lib/mc/extfs.d/iso9660
after a while. There is used awk where grep should be used. Awk exit code
doesn't reflect if pattern is found or not. I'm surprised, why awk is
used there. Attached is a patch, that replaces awk with grep.

zito at bobek:/data/image$ /usr/lib/mc/extfs.d/iso9660.orig list systemrescuecd-x86-1.6.4.iso |grep -i zip
-r--r--r--   1 root root          819988 Mar  2 2010 BOOTPROG/GRUB4DOS_0_4_4.ZIP;1
-r--r--r--   1 root root         5572421 Apr  1 2010 BOOTPROG/SYSLINUX_3_86.ZIP;1

fixed version:

zito at bobek:/data/image$ /usr/lib/mc/extfs.d/iso9660 list systemrescuecd-x86-1.6.4.iso |grep -i zip
-r--r--r--   1 root root          819988 Mar  2 2010 bootprog/grub4dos-0.4.4.zip
-r--r--r--   1 root root         5572421 Apr  1 2010 bootprog/syslinux-3.86.zip

Thanks for your work.
Best Regards

--- /usr/lib/mc/extfs.d/iso9660.orig    2010-09-08 11:41:19.000000000 +0200
+++ /usr/lib/mc/extfs.d/iso9660 2010-12-14 15:29:44.000000000 +0100
@@ -15,7 +15,7 @@
     fi
     if test -n "$CHARSET"; then
        CHARSET=`echo "$CHARSET" | tr '[A-Z]' '[a-z]' | sed -e 's/^iso-/iso/'`
-       isoinfo -j $CHARSET -i /dev/null 2>&1 | awk "/Iconv not yet supported|Unknown charset/" >/dev/null && CHARSET=
+       isoinfo -j $CHARSET -i /dev/null 2>&1 | grep "Iconv not yet supported\|Unknown charset" >/dev/null && CHARSET=
     fi
     if test -n "$CHARSET"; then
        JOLIET_OPT="-j $CHARSET -J"
@@ -23,7 +23,7 @@
        JOLIET_OPT="-J"
     fi
     ISOINFO="isoinfo -R"
-    isoinfo -d -i "$1" | awk "/UCS level 1|NO Joliet/" > /dev/null || ISOINFO="$ISOINFO $JOLIET_OPT"
+    isoinfo -d -i "$1" | grep "UCS level 1\|NO Joliet" > /dev/null || ISOINFO="$ISOINFO $JOLIET_OPT"
 }
 
 mcisofs_list () {