msg-patch needs to be checked by experts

Vit R vit_r at list.ru
Sun Mar 29 15:33:39 UTC 2009




    Good morning to the MC-dev-team !

    my name is Vit Rosin (Moscow) <vit_r at list.ru> 


I.
    Such `#include' as:
    #include "../dir/foo.h" 
    which is followed in .deps
    by gap `/../' (like in this: "/DIR/../dir/foo.h") 
    can bring unclear problems.

    It really happened, that only single line changed
    _from_:
    #include "../dir/foo.h"
    _to_:
    #include "dir/foo.h"
    was inafe to get out from ...
    (unpolitly speaking: use "../dir/foo.h" and sooner or latter you'll see from what)


    My attached to this msg patch needs to be checked by experts,
 
    i.e. because of a few `"../', <- still left there.
    _and_:
 
    #include <mhl/*.h>
    may be (i'm asking):     
    #include "mhl/*.h" ?


II.
    Has it some meaning:
    maint/template.c:32:
    #include "..."


III.
    QOTD from
       ~/ % info '(automake)Extending aclocal' :

    "
        Starting with Automake 1.8, `aclocal' will warn about all
    underquoted calls to `AC_DEFUN'...
    # bad style
         AC_PREREQ(2.57)
         AC_DEFUN(AX_FOOBAR,
         [AC_REQUIRE([AX_SOMETHING])dnl
    # should be rewritten as
         AC_DEFUN([AX_FOOBAR], [AC_PREREQ([2.57])dnl
         AC_REQUIRE([AX_SOMETHING])dnl

    "


Surely, MC is in good hands now

With best wishes to dev-team

Thanks sincerely

Vit

2009-03-29






-------------- next part --------------
A non-text attachment was scrubbed...
Name: include.diff
Type: application/octet-stream
Size: 37190 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20090329/2632cbda/attachment.obj>


More information about the mc-devel mailing list