[PATCH] trivial optimization in file.c::panel_operate()

Denys Vlasenko vda.linux at googlemail.com
Wed Jun 17 13:14:07 UTC 2009


Hi Slava,

I noticed an incorrectly indented if() in file.c::panel_operate().
Took a better look, and found out it can be tweaked in several ways.

This patch is the result.
It contains the following trivial optimizations:

* merged two identical "dest_dir_ = g_strdup (dest_dir)" ops.
* simplified check for trailing '/' (no need to strcmp 1-char string).
* since g_free (NULL) is safe, merged two separate
  "if empty string then bail out" code paths.
* fixed wording in a comment.

Slava, is it ok to send patches in attachments?

Do you want kernel-style "Signed-off-by" lines in patch submissions?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-patch
Size: 1367 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20090617/8c168fc7/attachment.bin>


More information about the mc-devel mailing list