[Midnight Commander] #180: (mandriva) concat_dir_and_file() + NULL parameter fix

Ticket System tickets at midnight-commander.org
Fri Jan 30 22:10:32 UTC 2009


#180: (mandriva) concat_dir_and_file() + NULL parameter fix
----------------------+-----------------------------------------------------
  Reporter:  metux    |       Owner:                           
      Type:  defect   |      Status:  new                      
  Priority:  major    |   Milestone:  4.6.3                    
 Component:  mc-core  |     Version:  4.6.1                    
Resolution:           |    Keywords:  review mandriva vote-styx
  Blocking:           |   Blockedby:                           
----------------------+-----------------------------------------------------

Comment(by guanx):

 Replying to [ticket:180 metux]:
 > http://svn.mandriva.com/cgi-
 bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc-
 concat.patch?view=markup

 Here: const char *file = filename;
 Why a separate variable for the filename pointer?

 And, in the patch, there is this comment:
 /* Is this one: *file == PATH_SEP seems to be not fully portable? */
 It's also confusing.

-- 
Ticket URL: <www.midnight-commander.org/ticket/180#comment:3>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center


More information about the mc-devel mailing list