[Midnight Commander] #188: (mandriva) show free space

Ticket System tickets at midnight-commander.org
Fri Jan 30 08:27:11 UTC 2009


#188: (mandriva) show free space
--------------------------+-------------------------------------------------
  Reporter:  metux        |       Owner:                 
      Type:  enhancement  |      Status:  new            
  Priority:  major        |   Milestone:  4.7            
 Component:  mc-core      |     Version:  4.6.1          
Resolution:               |    Keywords:  review mandriva
  Blocking:               |   Blockedby:                 
--------------------------+-------------------------------------------------

Comment(by andrew_b):

 I've modified this patch (see attachment). Differences:

 * info format is changed from (as an example) "5M (50%) of 10M" to "
 5M/10M (50%) ". So we don't need to translate it.
 * show_free_space() function is moved from main.c to screen.c. Now this
 function is called in show_dir() function only. Related global variables
 are moved into show_free_space() and made static.

 But there is a problem as in Mandriva/RH patch as in mine one. The
 init_my_statfs() function is called many times, therefore we have the
 memory leak.

-- 
Ticket URL: <www.midnight-commander.org/ticket/188#comment:2>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center


More information about the mc-devel mailing list