[Midnight Commander] #93: cons.saver: open the console in non-blocking mode
Ticket System
tickets at midnight-commander.org
Sat Jan 3 19:19:01 UTC 2009
#93: cons.saver: open the console in non-blocking mode
-------------------------+--------------------------------------------------
Reporter: slavazanko | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: mc-core | Version:
Resolution: | Keywords:
Blocking: | Blockedby:
-------------------------+--------------------------------------------------
Comment(by metux):
''Comment from Miguel (on the list):''
Opening the console in non-blocking mode is a bad idea,
as it means that every call that is done later on the
console_fd needs to check for EWOULDBLOCK. Most of the time,
it would be not return that, it would
only return that under
unique situations which means that testing this
patch would
not only be non-trivial, but someone would have to audit
all the code paths.
Also, this is lacking a ChangeLog explaining why this is needed.
But I think that this patch should not be applied, it seems
like a workaround that has not been properly implemented.
--
Ticket URL: <http://www.midnight-commander.org/ticket/93#comment:1>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center
More information about the mc-devel
mailing list