Compilation error: some mhl_* remainders

Mikhail styx.mp at gmail.com
Tue Feb 17 17:58:06 UTC 2009


2009/2/17 David Sterba <dave at jikos.cz>

> Hi,
>
> compilation of master @ cc69f5d2784ab253d795d9c842a2eeec6a187eb5
> fails with
>
> screen.o: In function `show_free_space':
> /home/dsterba/_dev/mc-build/src/screen.c:783: undefined reference to
> `mhl_mem_free'
> /home/dsterba/_dev/mc-build/src/screen.c:784: undefined reference to
> `mhl_str_dup'
>
> looks like a remainder of mhl removal.
>
> I was not sure which branch should be taken as the reference for latest
> development and tried origin/HEAD with same result. Patch below.
>
> cheers,
> dave
>
> --
>
> Fix compilation error
> screen.o: In function `show_free_space':
> /home/dsterba/_dev/mc-build/src/screen.c:783: undefined reference to
> `mhl_mem_free'
> /home/dsterba/_dev/mc-build/src/screen.c:784: undefined reference to
> `mhl_str_dup'
>
> Signed-off-by: David Sterba <dave at jikos.cz>
>
> --
> diff --git a/src/screen.c b/src/screen.c
> index b069b17..0b8920e 100644
> --- a/src/screen.c
> +++ b/src/screen.c
> @@ -780,8 +780,8 @@ show_free_space (WPanel *panel)
>        char rpath[PATH_MAX];
>
>        init_my_statfs ();
> -       mhl_mem_free (old_cwd);
> -       old_cwd = mhl_str_dup (panel->cwd);
> +       g_free (old_cwd);
> +       old_cwd = g_strdup (panel->cwd);
>
>        if (mc_realpath (panel->cwd, rpath) == NULL)
>            return;
>
> _______________________________________________
> Mc-devel mailing list
> http://mail.gnome.org/mailman/listinfo/mc-devel


Hi Dave,
Thank you for your work. I'll fix this in the nearest time.
Please post your patches in the tickets or like attach.
The best way is to use git format-patch.
It's a pity that such nonsense has been pushed to the master.
Some one need to be more carefull in voting...
cheers,
Mikhail S. Pobolovets
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20090217/33ec3a79/attachment.html>


More information about the mc-devel mailing list