[PATCH] Help Viewer - mouse issues

Grigory Trenin gtrenin at gmail.com
Fri Jan 5 00:32:39 UTC 2007


Pavel Tsekov wrote:

>On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote:
>
>This is patch is OK, but there are still problems.
>See this:
>
>  create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4,
>                                    ^^^^^^^^^^^^^^^^^^^^^^
>
>HELP_WINDOW_WIDTH already is large enough to hold the dialog
>frame. As a resylt if you try to click on the right hand side
>of the dialog you dont get any movement. I'd like to fix this
>before applying your patch so I can commit both fixes.
>Unfortunately removing the "+ 4" part is not enough to properly
>fix the problem. It seems like man2hlp is producing output
>with line lengths larget than HELP_TEXT_WIDTH which is incorrect
>IMO. I'll investigate and let you know what have I found. In
>the meantime if you want to help me - you are welcome :)
>  
>

So, there are two ways to get rid of that empty space on the right:

1) Shrink the window from 63 chars to HELP_TEXT_WIDTH (58 chars).
   This will cause some difficulties due to the usage of preformatted
   text - need to revise the help files for all languages, to check
   if they fit in the window, and fix them if necessary.

2) Expand HELP_TEXT_WIDTH to the effective window width (63 chars).
   IMHO this is better. Besides, I think it would be nice to leave
   a margin in one column between a text and a frame.
   Should I try and do it?
   What do you think?


Regards,
  Grigory







More information about the mc-devel mailing list