yet another utf8 patch: fix completion

Jindrich Novy jnovy at redhat.com
Thu Jan 4 09:00:43 UTC 2007


Hi Egmont,

On Tue, 2007-01-02 at 18:14 +0100, Egmont Koblinger wrote:
> Hi,
> 
> Especially to the maintainers of the UTF-8 patches: I've created another
> patch, this time to fix Alt+Tab (or Escape then TAB) completion when the
> command line or filename or whatever you type already contains some accented
> characters. The problem is caused by the UI widget telling the cursor
> position in characters, while the functions in complete.c expect them to
> refer to bytes.
> 
> This new patch can be found at the "usual" places:
> 
>   https://svn.uhulinux.hu/packages/2.0/mc/patches/
>   https://svn.uhulinux.hu/packages/dev/mc/patches/
> 
> and is called 00-84-utf8-complete.patch. As usual, unfortunately, "length"
> and "width" are not clearly distinguished, so it's unlikely to work
> correctly with double-width characters. To be applied on the top of the
> previous utf8 patches in numerical order (though it doesn't depend on all of
> them).

Just a question related to 00-84-utf8-complete.patch. Why do you replace
"if (SLsmg_Is_Unicode)" with "if (1)" in the implementation of
mbstrnlen() ? Will it work when mc is compiled with UTF-8 patches and
ran with non-UTF-8 locale?

Thanks,
Jindrich




More information about the mc-devel mailing list