[PATCH] Re: Segfault on loading of non existent syntax file

Leonard den Ottolander leonard at den.ottolander.nl
Mon Mar 27 20:12:48 UTC 2006


Hi Pavel,

On Mon, 2006-03-27 at 21:57 +0200, Leonard den Ottolander wrote:
> doesn't this cause a memory leak? Or is that memory freed
> elsewhere?

Last statement in the skipped edit_free_syntax_rules() is a
syntax_g_free(edit->rules). I guess we need a free.

The zeroing by g_malloc0 only obscures possible code issues so I'd vote
against it.

I'll use a syntax_g_free instead of a g_free in my patch. Plus I'll have
to check how "deeper" includes behave.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





More information about the mc-devel mailing list