From vadim-lvv at yandex.ru Wed Mar 1 14:18:49 2006 From: vadim-lvv at yandex.ru (vadim) Date: Wed, 1 Mar 2006 16:18:49 +0200 Subject: [patch] for mc.menu Message-ID: <200603011618.50014.vadim-lvv@yandex.ru> Hi! This is small patch for work with 7zip from mc.menu --- mc.menu.old 2004-08-17 11:31:16.000000000 +0300 +++ mc.menu 2006-02-26 19:57:35.000000000 +0200 @@ -50,6 +50,16 @@ 5 Compile and link current .c file make `basename %f .c` 2>/dev/null || cc -O -o `basename %f .c` %f += t d +7 Compress the current subdirectory (7z) + Pwd=`basename %d /` + echo -n "Name of the compressed file (without extension) [$Pwd]: " + read tar + if [ "$tar"x = x ]; then tar="$Pwd"; fi + cd .. && \ + 7za a -r $tar $Pwd && \ + echo "../$tar.7z created." + + t r & ! t t a Append file to opposite cat %f >>%D/%f @@ -325,6 +335,10 @@ fi shift done + ++ f \.7z | f \.gz$ | f \.tgz$ | f \.tpz$ | f \.Z$ | f \.z$ | f \.bz2$ | \.tar.gz$ | f \.tgz$ | f \.tpz$ | f \.tar.Z$ | f \.tar.z$ | f \.tar.bz2$ | f \.tar.F$ & t r & ! t t +e Extract compressed tar, gz, bz2 or 7z file using 7z + 7za x %f + x /usr/bin/open | x /usr/local/bin/open & x /bin/sh o Open next a free console ps in last time 7zip used more often and more often -- vadim From kerzum at mail.ru Wed Mar 1 16:44:09 2006 From: kerzum at mail.ru (Peter A. Kerzum) Date: Wed, 1 Mar 2006 19:44:09 +0300 Subject: XML extfs Message-ID: <200603011944.09358.kerzum@mail.ru> Hi, guys! I'm yet another mc fan :) Let me contribute XML extfs to stop all those FAR superiority discussions :). Let me start with a brief announce. * Requirements Extfs module is implemented in PERL and requires PERL XML::Simple module, that is not included in the std distribution. This module (as any other) could be installed with a single command perl -MCPAN -e 'install XML::Simple' * Features XML Extfs provides consistent read-only XML exploration features: - Listing of XML document. Attribute values and text content are included in the listing as part of names (eg: 'attr-name: value' or '.text: text-value') - Copyout of attr values, text values and elements. Elements are copied-out pretty-printed, in 'source' or 'no-attr' forms. * Bugs and limitations # - XML elements may be heavily reformatted on copyout # - Datetimes are not supported, so are file sizes for elements # - '/' sign in attribute values is unconditionally translated to '-' # - Low file size limit Please, let me know what do you think of this? -- Peter A. Kerzum -------------- next part -------------- A non-text attachment was scrubbed... Name: xml Type: application/x-perl Size: 4031 bytes Desc: not available URL: From savannah-bounces at gnu.org Wed Mar 1 17:11:50 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 1 Mar 2006 19:11:50 +0200 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20050711-172723.sv41304.44351@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> Message-ID: <20060301-191150.sv36205.83138@savannah.gnu.org> Update of bug #13733 (project mc): Status: None => Ready For Test Assigned to: None => ptsekov _______________________________________________________ Follow-up Comment #1: Please, test the attached patch. Comment, flames, etc will be much appreciated. _______________________________________________________ Additional Item Attachment: File name: mc-old_esc_mode.patch Size:8 KB _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From kerzum at mail.ru Wed Mar 1 17:52:48 2006 From: kerzum at mail.ru (Peter A. Kerzum) Date: Wed, 1 Mar 2006 20:52:48 +0300 Subject: Fwd: XML extfs Message-ID: <200603012052.48266.kerzum@mail.ru> Hi! Sorry, since my post I've found a number of bugs (with multiline text elements). Please, disregard previous version and have look at this one. ---------- Forwarded Message ---------- Subject: XML extfs Date: Wednesday 01 March 2006 19:44 From: "Peter A. Kerzum" To: mc-devel at gnome.org Hi, guys! I'm yet another mc fan :) Let me contribute XML extfs to stop all those FAR superiority discussions :). Let me start with a brief announce. * Requirements Extfs module is implemented in PERL and requires PERL XML::Simple module, that is not included in the std distribution. This module (as any other) could be installed with a single command perl -MCPAN -e 'install XML::Simple' * Features XML Extfs provides consistent read-only XML exploration features: - Listing of XML document. Attribute values and text content are included in the listing as part of names (eg: 'attr-name: value' or '.text: text-value') - Copyout of attr values, text values and elements. Elements are copied-out pretty-printed, in 'source' or 'no-attr' forms. * Bugs and limitations # - XML elements may be heavily reformatted on copyout # - Datetimes are not supported, so are file sizes for elements # - '/' sign in attribute values is unconditionally translated to '-' # - Low file size limit Please, let me know what do you think of this? -- Peter A. Kerzum ------------------------------------------------------- -- Peter A. Kerzum -------------- next part -------------- A non-text attachment was scrubbed... Name: xml Type: application/x-perl Size: 4230 bytes Desc: not available URL: From savannah-bounces at gnu.org Wed Mar 1 18:59:43 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Wed, 1 Mar 2006 19:59:43 +0100 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20060301-191150.sv36205.83138@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> <20060301-191150.sv36205.83138@savannah.gnu.org> Message-ID: <20060301-195943.sv41304.53632@savannah.gnu.org> Follow-up Comment #2, bug #13733 (project mc): first a correction on my side: meanwhile i did actually experience a sequence being torn apart, so the "one packet" theory simply does not hold. :( going slightly overboard, one could apply some heuristics to determine the worst-case line latency automatically. i'm not sure it is a good idea to make the timeout a proper option only. it makes sense to have the setting depend on the location, or rather on the route to the location. an env variable seems to be the by far the most appropriate means of achieving this. having separate settings for certain $TERM seems interesting as well, as i might want to extend the timeout for terms where i have to enter esc sequences manually - but that can be scripted in the startup script as well. other than that the patch seems reasonable (i did not test it, but i don't see any code paths which you could have skipped if you tested it at all ;). _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 1 19:17:35 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 1 Mar 2006 21:17:35 +0200 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20060301-195943.sv41304.53632@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> <20060301-191150.sv36205.83138@savannah.gnu.org> <20060301-195943.sv41304.53632@savannah.gnu.org> Message-ID: <20060301-211735.sv36205.5817@savannah.gnu.org> Follow-up Comment #3, bug #13733 (project mc): Well, one could always adjust it as per his immediate requirements. Have you noticed that I've added a new configuration dialog ? Why do you think an environment variable is more appropriate ? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 1 19:25:42 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Wed, 1 Mar 2006 20:25:42 +0100 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20060301-211735.sv36205.5817@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> <20060301-191150.sv36205.83138@savannah.gnu.org> <20060301-195943.sv41304.53632@savannah.gnu.org> <20060301-211735.sv36205.5817@savannah.gnu.org> Message-ID: <20060301-202542.sv41304.21334@savannah.gnu.org> Follow-up Comment #4, bug #13733 (project mc): > Well, one could always adjust it as per his immediate requirements. > this is *slow*. and extremely annoying if done several times a day. > Have you noticed that I've added a new configuration dialog ? > no, i did not read your patch. ;-) > Why do you think an environment variable is more appropriate ? > it is scriptable. without sed-ing the config file, that is. in the scenarios i drafted this option is rather imposed by the operation environment than by user preference, so it just makes sense to use something that is naturally part of the environment. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 1 19:47:47 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 1 Mar 2006 21:47:47 +0200 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20060301-202542.sv41304.21334@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> <20060301-191150.sv36205.83138@savannah.gnu.org> <20060301-195943.sv41304.53632@savannah.gnu.org> <20060301-211735.sv36205.5817@savannah.gnu.org> <20060301-202542.sv41304.21334@savannah.gnu.org> Message-ID: <20060301-214746.sv36205.72838@savannah.gnu.org> Follow-up Comment #5, bug #13733 (project mc): > > Well, one could always adjust it as per his immediate requirements. > > > this is *slow*. and extremely annoying if done several times a day. Maybe I am missing the point but I cannot imagine why one would need to adjust it more than once. Maybe if one logs into a single network host from multiple sources... But still this option makes sense mostly when used on a local machine. I think that beyond certain values enabling this option is not usefull at all. > > Have you noticed that I've added a new configuration dialog ? > > > no, i did not read your patch. ;-) You could try it at least :) It doesn't change the default behaviour it just adds the ability to configure old_esc_mode and the related timeout (I should have mentioned that earlier). > > Why do you think an environment variable is more appropriate ? > > > it is scriptable. without sed-ing the config file, that is. > in the scenarios i drafted this option is rather imposed by the operation > environment than by user preference, so it just makes sense to use something > that is naturally part of the environment. In this case Denis Vlasenko's patch should suffice. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 1 20:09:41 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Wed, 1 Mar 2006 21:09:41 +0100 Subject: [bug #13733] escape key timeout stuff In-Reply-To: <20060301-214746.sv36205.72838@savannah.gnu.org> References: <20050711-172723.sv41304.44351@savannah.gnu.org> <20060301-191150.sv36205.83138@savannah.gnu.org> <20060301-195943.sv41304.53632@savannah.gnu.org> <20060301-211735.sv36205.5817@savannah.gnu.org> <20060301-202542.sv41304.21334@savannah.gnu.org> <20060301-214746.sv36205.72838@savannah.gnu.org> Message-ID: <20060301-210941.sv41304.65873@savannah.gnu.org> Follow-up Comment #6, bug #13733 (project mc): > [...] I cannot imagine why one would need to adjust it more than once. > you can log into the same machine from different sources - locally, through serial line, through networks with different latencies. and also you can share the same config among several machines if you have a networked home. both cases are not exactly exceptional in heterogenous environments like unis or even when simply ssh-ing into your box at home. > > no, i did not read your patch. ;-) > > You could try it at least :) [...] > oil your irony detector, dude. ;) > In this case Denis Vlasenko's patch should suffice. > i think the env var should override the setting, but both make sense. ideally, the config dialog would show whether the setting will take effect - to avoid surprises. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From pete4abw at comcast.net Fri Mar 3 11:41:07 2006 From: pete4abw at comcast.net (Peter) Date: Fri, 03 Mar 2006 06:41:07 -0500 Subject: C-x i (info panel) returns to wrong directory Message-ID: Using MC 4.6.0 GNU Midnight Commander 4.6.0 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, smbfs With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support With multiple codepages support When viewing two file lists, if user presses C-x i for info on a panel's directory or file, the info pops up correctly in the other panel. However, when the user closes the info screen, the directory of the current panel is shown -- NOT the directory which was being viewed before the info panel appeared. Sorry if this is confusing. Let me illustrate: Left Right \ \usr\bin User is in left panel Presses C-x i (or selects Info from the Right Panel menu) Info panel appears in Right panel User presses C-x i again to toggle info off (or selects listing mode from Right Panel menu) Right directory panel now shows \, not \usr\bin IMO, after info is closed, whatever was in the panel should be restored. From kerzum at mail.ru Fri Mar 3 16:11:34 2006 From: kerzum at mail.ru (Peter A. Kerzum) Date: Fri, 3 Mar 2006 19:11:34 +0300 Subject: Fwd: XML extfs In-Reply-To: <200603012052.48266.kerzum@mail.ru> References: <200603012052.48266.kerzum@mail.ru> Message-ID: <200603031911.34843.kerzum@mail.ru> Hi! Sorry, I really dont want to be annoying =) But is not this interesting at all? Don't you like extfs idea? Don't you think about expanding the power of extfs to the entire world of data formats? Isn't it time to start with a more agresive kind of extfs initiative? Won't it be nice to 'cd' into the thing you are working with, be it MOF (Meta object format) declaration, a network session from tcpdump -w, multipart email message or alike? Please tell =) I'm looking forward to hearing from you! > ---------- Forwarded Message ---------- > > Subject: XML extfs > Date: Wednesday 01 March 2006 19:44 > From: "Peter A. Kerzum" > To: mc-devel at gnome.org > > Hi, guys! > > Let me contribute XML extfs to stop all those FAR superiority > discussions :). Let me start with a brief announce. > > * Requirements > Extfs module is implemented in PERL and requires PERL XML::Simple > module, that is not included in the std distribution. This module (as > any other) could be installed with a single command > perl -MCPAN -e 'install XML::Simple' > > * Features > XML Extfs provides consistent read-only XML exploration features: > - Listing of XML document. Attribute values and text content are > included in the listing as part of names (eg: 'attr-name: value' or > '.text: text-value') > - Copyout of attr values, text values and elements. Elements are > copied-out pretty-printed, in 'source' or 'no-attr' forms. > > * Bugs and limitations > # - XML elements may be heavily reformatted on copyout > # - Datetimes are not supported, so are file sizes for elements > # - '/' sign in attribute values is unconditionally translated to '-' > # - Low file size limit > > > Please, let me know what do you think of this? > > > -- > Peter A. Kerzum > > ------------------------------------------------------- -- Peter A. Kerzum -------------- next part -------------- A non-text attachment was scrubbed... Name: xml Type: application/x-perl Size: 4229 bytes Desc: not available URL: From ptsekov at gmx.net Fri Mar 3 19:08:57 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 3 Mar 2006 21:08:57 +0200 Subject: Fwd: XML extfs In-Reply-To: <200603031911.34843.kerzum@mail.ru> References: <200603012052.48266.kerzum@mail.ru> <200603031911.34843.kerzum@mail.ru> Message-ID: Hello Peter, Please, calm down a bit . I understand your enthusiasm, but sending basically the same message to all subscribers of this list three times is a little bit too much. You will not get the desired attention by simple wasting bandwidth. I am sure your patch will be reviewed as the time allows. On Fri, 3 Mar 2006, Peter A. Kerzum wrote: > Hi! > > Sorry, I really dont want to be annoying =) > But is not this interesting at all? > Don't you like extfs idea? > Don't you think about expanding the power of extfs to the entire world > of data formats? Isn't it time to start with a more agresive kind of > extfs initiative? Won't it be nice to 'cd' into the thing you are > working with, be it MOF (Meta object format) declaration, a network > session from tcpdump -w, multipart email message or alike? > > Please tell =) I'm looking forward to hearing from you! > > > > ---------- Forwarded Message ---------- > > > > Subject: XML extfs > > Date: Wednesday 01 March 2006 19:44 > > From: "Peter A. Kerzum" > > To: mc-devel at gnome.org > > > > Hi, guys! > > > > Let me contribute XML extfs to stop all those FAR superiority > > discussions :). Let me start with a brief announce. > > > > * Requirements > > Extfs module is implemented in PERL and requires PERL XML::Simple > > module, that is not included in the std distribution. This module (as > > any other) could be installed with a single command > > perl -MCPAN -e 'install XML::Simple' > > > > * Features > > XML Extfs provides consistent read-only XML exploration features: > > - Listing of XML document. Attribute values and text content are > > included in the listing as part of names (eg: 'attr-name: value' or > > '.text: text-value') > > - Copyout of attr values, text values and elements. Elements are > > copied-out pretty-printed, in 'source' or 'no-attr' forms. > > > > * Bugs and limitations > > # - XML elements may be heavily reformatted on copyout > > # - Datetimes are not supported, so are file sizes for elements > > # - '/' sign in attribute values is unconditionally translated to '-' > > # - Low file size limit > > > > > > Please, let me know what do you think of this? > > > > > > -- > > Peter A. Kerzum > > > > ------------------------------------------------------- > > -- > Peter A. Kerzum > From savannah-bounces at gnu.org Mon Mar 6 07:28:42 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 09:28:42 +0200 Subject: [bug #16008] C-x i (info panel) returns to wrong directory Message-ID: <20060306-092841.sv36205.26095@savannah.gnu.org> URL: Summary: C-x i (info panel) returns to wrong directory Project: GNU Midnight Commander Submitted by: ptsekov Submitted on: Mon 03/06/06 at 09:28 Category: Core Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: 4.6.0 Platform Version: All _______________________________________________________ Details: This bug report was originally submitted to the developers mailing list: Using MC 4.6.0 GNU Midnight Commander 4.6.0 Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, smbfs With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support With multiple codepages support When viewing two file lists, if user presses C-x i for info on a panel's directory or file, the info pops up correctly in the other panel. However, when the user closes the info screen, the directory of the current panel is shown -- NOT the directory which was being viewed before the info panel appeared. Sorry if this is confusing. Let me illustrate: Left Right \ \usr\bin User is in left panel Presses C-x i (or selects Info from the Right Panel menu) Info panel appears in Right panel User presses C-x i again to toggle info off (or selects listing mode from Right Panel menu) Right directory panel now shows \, not \usr\bin IMO, after info is closed, whatever was in the panel should be restored. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 08:35:11 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 10:35:11 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060224-074709.sv14402.57728@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> Message-ID: <20060306-103511.sv36205.68323@savannah.gnu.org> Follow-up Comment #8, bug #13101 (project mc): ftpfs_first_cd_then_ls set to 0 is unreliable. In fact ftpfs_first_cd_then_ls is set by default for some time now. Of course I should have mentioned that :( Anyway I'll see why the patch breaks the old behaviour when ftpfs_first_cd_then_ls is unset. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 08:36:25 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 10:36:25 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060306-103511.sv36205.68323@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> Message-ID: <20060306-103624.sv36205.54849@savannah.gnu.org> Update of bug #13101 (project mc): Platform Version: GNU/Linux => All _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From pete4abw at comcast.net Mon Mar 6 13:20:15 2006 From: pete4abw at comcast.net (Peter) Date: Mon, 06 Mar 2006 08:20:15 -0500 Subject: [bug #16008] C-x i (info panel) returns to wrong directory References: <20060306-092841.sv36205.26095@savannah.gnu.org> Message-ID: On Mon, 06 Mar 2006 09:28:42 +0200, Pavel Tsekov wrote: > > URL: > > > Summary: C-x i (info panel) returns to wrong directory snip... Thank you for submitting. I was not sure it was a bug, so that is why I posted the note here. Let me know if I can help in any way. -- Peter From ptsekov at gmx.net Mon Mar 6 15:34:36 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Mon, 6 Mar 2006 17:34:36 +0200 Subject: redundant code in ftpfs? In-Reply-To: <20060205204036.D686C900F6@mail.mplayerhq.hu> References: <20060205204036.D686C900F6@mail.mplayerhq.hu> Message-ID: On Sun, 5 Feb 2006, Arpi wrote: > p = ftpfs_translate_path (me, super, remote_path); > if (ftpfs_chdir_internal (me, super, p) != COMPLETE) { > ... > } > g_free (p); > > the ftpfs_translate_path() call and the 'p' pointer are redundant here, > as ftpfs_translate_path is also called from inside ftpfs_chdir_internal() > on the p parameter. so now it's done twice, which is redundant, and > may be a problem too... I have removed the extra call to ftpfs_translate_path() and the related code from the CVS version of ftpfs.c. Thanks! From savannah-bounces at gnu.org Mon Mar 6 09:32:12 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 11:32:12 +0200 Subject: [bug #14155] 4.6.1: mouse wheel strangeness In-Reply-To: <20060211-193147.sv36205.34816@savannah.gnu.org> References: <20050817-074744.sv43353.70170@savannah.gnu.org> <20050817-074903.sv43353.82514@savannah.gnu.org> <20050824-171346.sv36205.27820@savannah.gnu.org> <20050824-171735.sv36205.42088@savannah.gnu.org> <20050824-171818.sv36205.45764@savannah.gnu.org> <20050824-233159.sv43353.32054@savannah.gnu.org> <20050825-150703.sv36205.9257@savannah.gnu.org> <20050825-151457.sv36205.18729@savannah.gnu.org> <20050825-151636.sv36205.74102@savannah.gnu.org> <20050825-223719.sv26390.98103@savannah.gnu.org> <20050827-134801.sv26390.3244@savannah.gnu.org> <20050901-004852.sv0.99366@savannah.gnu.org> <20050901-005930.sv0.27393@savannah.gnu.org> <20050901-115641.sv36205.75443@savannah.gnu.org> <20050901-125632.sv36205.52926@savannah.gnu.org> <20050901-130624.sv36205.11367@savannah.gnu.org> <20050901-125903.sv0.26846@savannah.gnu.org> <20050901-160529.sv36205.41473@savannah.gnu.org> <20050928-192305.sv26390.73092@savannah.gnu.org> <20060204-124239.sv20990.85675@savannah.gnu.org> <20060205-18 2853.sv36205.4062@savannah.gnu.org> <20060206-162416.sv36205.99349@savannah.gnu.org> <20060206-170248.sv36205.51816@savannah.gnu.org> <20060206-171801.sv36205.40773@savannah.gnu.org> <20060206-233551.sv43353.92961@savannah.gnu.org> <20060207-112156.sv36205.91051@savannah.gnu.org> <20060211-094438.sv47312.91557@savannah.gnu.org> <20060211-193147.sv36205.34816@savannah.gnu.org> Message-ID: <20060306-113212.sv36205.16134@savannah.gnu.org> Follow-up Comment #24, bug #14155 (project mc): I've applied a slightly modified version of mc-xterm-mouse-tweak.patch. The difference is that the applied patch doesn't try to dereference a NULL pointer if the COLORTERM environment variable is not set. So, Roland, if you are reading, please, give MC a try and let me know if the things improved for you. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 13:16:04 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 15:16:04 +0200 Subject: [bug #9631] Cannot "put tabs only where I want them" In-Reply-To: <20060306-151550.sv36205.64029@savannah.gnu.org> References: <20050516-142017.sv26390.49945@savannah.gnu.org> <20050516-164632.sv41304.19268@savannah.gnu.org> <20050516-205508.sv26390.60900@savannah.gnu.org> <20050516-210803.sv26390.58748@savannah.gnu.org> <20050516-211552.sv41304.32882@savannah.gnu.org> <20060126-105308.sv36205.93199@savannah.gnu.org> <20060126-105522.sv36205.46546@savannah.gnu.org> <20060126-113717.sv41304.80574@savannah.gnu.org> <20060126-120205.sv41304.23507@savannah.gnu.org> <20060126-141856.sv36205.18810@savannah.gnu.org> <20060126-133230.sv41304.9843@savannah.gnu.org> <20060126-150606.sv36205.68330@savannah.gnu.org> <20060126-152726.sv36205.13842@savannah.gnu.org> <20060126-161322.sv41304.3817@savannah.gnu.org> <20060126-172508.sv36205.10434@savannah.gnu.org> <20060126-174958.sv36205.11003@savannah.gnu.org> <20060126-183101.sv41304.62174@savannah.gnu.org> <20060306-151550.sv36205.64029@savannah.gnu.org> Message-ID: <20060306-151604.sv36205.8624@savannah.gnu.org> Update of bug #9631 (project mc): Open/Closed: Open => Closed _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 13:15:50 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 15:15:50 +0200 Subject: [bug #9631] Cannot "put tabs only where I want them" In-Reply-To: <20060126-183101.sv41304.62174@savannah.gnu.org> References: <20050516-142017.sv26390.49945@savannah.gnu.org> <20050516-164632.sv41304.19268@savannah.gnu.org> <20050516-205508.sv26390.60900@savannah.gnu.org> <20050516-210803.sv26390.58748@savannah.gnu.org> <20050516-211552.sv41304.32882@savannah.gnu.org> <20060126-105308.sv36205.93199@savannah.gnu.org> <20060126-105522.sv36205.46546@savannah.gnu.org> <20060126-113717.sv41304.80574@savannah.gnu.org> <20060126-120205.sv41304.23507@savannah.gnu.org> <20060126-141856.sv36205.18810@savannah.gnu.org> <20060126-133230.sv41304.9843@savannah.gnu.org> <20060126-150606.sv36205.68330@savannah.gnu.org> <20060126-152726.sv36205.13842@savannah.gnu.org> <20060126-161322.sv41304.3817@savannah.gnu.org> <20060126-172508.sv36205.10434@savannah.gnu.org> <20060126-174958.sv36205.11003@savannah.gnu.org> <20060126-183101.sv41304.62174@savannah.gnu.org> Message-ID: <20060306-151550.sv36205.64029@savannah.gnu.org> Update of bug #9631 (project mc): Status: None => Fixed _______________________________________________________ Follow-up Comment #18: I am closing this bug report as fixed. Feel free to reopen if needed. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 13:31:57 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Mon, 6 Mar 2006 15:31:57 +0200 Subject: [bug #14155] 4.6.1: mouse wheel strangeness In-Reply-To: <20060306-113212.sv36205.16134@savannah.gnu.org> References: <20050817-074744.sv43353.70170@savannah.gnu.org> <20050817-074903.sv43353.82514@savannah.gnu.org> <20050824-171346.sv36205.27820@savannah.gnu.org> <20050824-171735.sv36205.42088@savannah.gnu.org> <20050824-171818.sv36205.45764@savannah.gnu.org> <20050824-233159.sv43353.32054@savannah.gnu.org> <20050825-150703.sv36205.9257@savannah.gnu.org> <20050825-151457.sv36205.18729@savannah.gnu.org> <20050825-151636.sv36205.74102@savannah.gnu.org> <20050825-223719.sv26390.98103@savannah.gnu.org> <20050827-134801.sv26390.3244@savannah.gnu.org> <20050901-004852.sv0.99366@savannah.gnu.org> <20050901-005930.sv0.27393@savannah.gnu.org> <20050901-115641.sv36205.75443@savannah.gnu.org> <20050901-125632.sv36205.52926@savannah.gnu.org> <20050901-130624.sv36205.11367@savannah.gnu.org> <20050901-125903.sv0.26846@savannah.gnu.org> <20050901-160529.sv36205.41473@savannah.gnu.org> <20050928-192305.sv26390.73092@savannah.gnu.org> <20060204-124239.sv20990.85675@savannah.gnu.org> <20060205-18 2853.sv36205.4062@savannah.gnu.org> <20060206-162416.sv36205.99349@savannah.gnu.org> <20060206-170248.sv36205.51816@savannah.gnu.org> <20060206-171801.sv36205.40773@savannah.gnu.org> <20060206-233551.sv43353.92961@savannah.gnu.org> <20060207-112156.sv36205.91051@savannah.gnu.org> <20060211-094438.sv47312.91557@savannah.gnu.org> <20060211-193147.sv36205.34816@savannah.gnu.org> <20060306-113212.sv36205.16134@savannah.gnu.org> Message-ID: <20060306-153157.sv36205.31998@savannah.gnu.org> Update of bug #14155 (project mc): Assigned to: leonardjo => ptsekov _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Mon Mar 6 19:05:52 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Mon, 6 Mar 2006 20:05:52 +0100 Subject: [bug #16017] viewer position from "find file" dialog vs. parsed files Message-ID: <20060306-200552.sv41304.9640@savannah.gnu.org> URL: Summary: viewer position from "find file" dialog vs. parsed files Project: GNU Midnight Commander Submitted by: ossi Submitted on: Mon 03/06/06 at 20:05 Category: Viewer Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: current (CVS or snapshot) Platform Version: All _______________________________________________________ Details: the "find file" dialog does seaching on unfiltered file contents. it tells the viewer to start viewing a the line of the match. however, if the file is filtered ("parsed", as opposed to "raw") before viewing (e.g., lynx -dump), the line number is applied to the filtered output - usually with "suboptimal" results. i'm not sure what to do about this. translating the line numbers would require cooperation from the filter, which is sort of impossible for external filters. and grepping on filtered files would be sloooow. maybe like this: if matches are found and the file is "formattable", filter it and grep again and display that as the result. alternatively, force the viewer into raw mode, but i would not like this. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Tue Mar 7 20:55:39 2006 From: savannah-bounces at gnu.org (hacinn) Date: Tue, 7 Mar 2006 20:55:39 +0000 Subject: [bug #16029] MC doesn't open if network gateway inaccessible. Message-ID: <20060307-205539.sv47834.77141@savannah.gnu.org> URL: Summary: MC doesn't open if network gateway inaccessible. Project: GNU Midnight Commander Submitted by: hacinn Submitted on: Tue 03/07/06 at 20:55 Category: None Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: 4.6.0-pre3 Platform Version: GNU/Linux _______________________________________________________ Details: I am using Linux Debian 3.1 and i have set my interface file with: iface eth0 inet static address 192.168.1.10 netmask 255.255.255.0 gateway 192.168.1.1 If I unplug the network cable and try to open MC, MC doesn't open. If I comment field gateway in interfaces file and keep the cable network unpluged, then MC open normally. If I plug the cable and uncomment field gateway, the MC open normally too. _______________________________________________________ Carbon-Copy List: CC Address | Comment ------------------------------------+----------------------------- hacinn | _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Tue Mar 7 21:31:48 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Tue, 7 Mar 2006 22:31:48 +0100 Subject: [bug #16029] MC doesn't open if network gateway inaccessible. In-Reply-To: <20060307-205539.sv47834.77141@savannah.gnu.org> References: <20060307-205539.sv47834.77141@savannah.gnu.org> Message-ID: <20060307-223148.sv41304.24776@savannah.gnu.org> Follow-up Comment #1, bug #16029 (project mc): i think that's some call to gethostbyname(). if the route is known to be broken, it fails immediately. if the cable is pulled, it has to time out. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 8 15:00:48 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 8 Mar 2006 17:00:48 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060306-103624.sv36205.54849@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> Message-ID: <20060308-170047.sv36205.6244@savannah.gnu.org> Follow-up Comment #9, bug #13101 (project mc): I've just checked in a patch which improves ftpfs_dir_load(). It enables the attached patch to work no matter whether `ftpfs_first_cd_then_ls' is set or not. So if you checkout the source from cvs it should work. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 8 15:02:04 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 8 Mar 2006 17:02:04 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060308-170047.sv36205.6244@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> <20060308-170047.sv36205.6244@savannah.gnu.org> Message-ID: <20060308-170204.sv36205.85604@savannah.gnu.org> Follow-up Comment #10, bug #13101 (project mc): If it is not clear you still should apply the patch attached to this bugreport since I haven't commited that yet. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From ptsekov at gmx.net Wed Mar 8 15:50:32 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Wed, 8 Mar 2006 17:50:32 +0200 Subject: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> Message-ID: On Mon, 6 Feb 2006, Pavel Tsekov wrote: > > deb-support-without-dpkg.patch > > For systems withoput dpkg (almost any non-debian OS). > > It handles .deb files as regular .ar archives, as they are in reality. > > This would be nice addition. Only if we could avoid the 'O' option of gnu > tar... Does anyone know of a way to avoid it ? In any case I think this > patch is worth adding. I've played with this patch again and I found a problem. In fact it is a problem in uar... When I press enter on either a .deb file or .a file I get directory listing containing file names like this: [excerpt from libc.a] 2005 C-address.o 2005 C-collate.o 2005 C-ctype.o [excerpt from mc_4.6.1-1_i386.deb] 2005 control.tar.gz 2005 data.tar.gz 2005 debian-binary See bellow the output of `ar tv' on the files above: [libc.a] rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o rw-r--r-- 250/250 932 Nov 4 04:56 2005 C-messages.o rw-r--r-- 250/250 1372 Nov 4 04:56 2005 C-monetary.o rw-r--r-- 250/250 896 Nov 4 04:56 2005 C-numeric.o rw-r--r-- 250/250 3728 Nov 4 04:56 2005 C-time.o rw-r--r-- 250/250 788 Nov 4 04:56 2005 C-paper.o rw-r--r-- 250/250 952 Nov 4 04:56 2005 C-name.o rw-r--r-- 250/250 1132 Nov 4 04:56 2005 C-address.o rw-r--r-- 250/250 904 Nov 4 04:56 2005 C-telephone.o rw-r--r-- 250/250 868 Nov 4 04:56 2005 C-measurement.o rw-r--r-- 250/250 1528 Nov 4 04:56 2005 C-identification.o rw-r--r-- 250/250 2248 Nov 4 04:56 2005 C-collate.o [mc_4.6.1-1_i386.deb] rw-r--r-- 0/0 4 Oct 16 18:30 2005 debian-binary rw-r--r-- 0/0 5798 Oct 16 18:30 2005 control.tar.gz rw-r--r-- 0/0 2135380 Oct 16 18:30 2005 data.tar.gz It is obvious that the list command of uar doesn't process the output properly and produces bad filenames. The test was done on Fedora Core 3 (i386) ar is from binutils-2.15.92.0.2-5.1 From ptsekov at gmx.net Wed Mar 8 16:35:22 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Wed, 8 Mar 2006 18:35:22 +0200 Subject: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> Message-ID: On Wed, 8 Mar 2006, Pavel Tsekov wrote: > On Mon, 6 Feb 2006, Pavel Tsekov wrote: > > > > deb-support-without-dpkg.patch > > > For systems withoput dpkg (almost any non-debian OS). > > > It handles .deb files as regular .ar archives, as they are in reality. > > > > This would be nice addition. Only if we could avoid the 'O' option of gnu > > tar... Does anyone know of a way to avoid it ? In any case I think this > > patch is worth adding. > > I've played with this patch again and I found a problem. In fact it is a > problem in uar... > > When I press enter on either a .deb file or .a file I get directory > listing containing file names like this: > > [excerpt from libc.a] > 2005 C-address.o > 2005 C-collate.o > 2005 C-ctype.o > > [excerpt from mc_4.6.1-1_i386.deb] > 2005 control.tar.gz > 2005 data.tar.gz > 2005 debian-binary This may be blamed to vfs_parse_ls_lga() too since it processes the output of the extfs "list" command. Oh, well... From leonard at den.ottolander.nl Wed Mar 8 16:35:37 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Wed, 08 Mar 2006 17:35:37 +0100 Subject: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> Message-ID: <1141835737.2526.7.camel@athlon> Hello Pavel, On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: > rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o > It is obvious that the list command of uar doesn't process > the output properly and produces bad filenames. This is most probably caused by the fact that I removed the optional parsing of a fourth date field in vfs_parse_file_date() in utilvfs.c. Please do *not* restore the old behaviour as it is incapable of distinguishing between 3 and 4 field dates reliable. Instead a new function vfs_parse_file_date_4() should be created that is called explicitly for dates that are known to have four date fields. The old function can then be used for dates with three fields. I'm quite willing to implement this function (it's mostly a duplicate of the existing one), but please give me until next weekend. Thanks. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Wed Mar 8 17:22:24 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Wed, 08 Mar 2006 18:22:24 +0100 Subject: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: <1141835737.2526.7.camel@athlon> References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141835737.2526.7.camel@athlon> Message-ID: <1141838545.2526.19.camel@athlon> Hi, On Wed, 2006-03-08 at 17:35 +0100, Leonard den Ottolander wrote: > On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: > > rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o > Instead a new function vfs_parse_file_date_4() should be created that is > called explicitly for dates that are known to have four date fields. The > old function can then be used for dates with three fields. Hm. Still leaves the fact that vfs_parse_ls_lga() should be capable to distinguish between 3 and 4 field dates. This would require a rewrite of that function to distinguish between 3 and 4 field dates. Not trivial. The easier approach probably is to filter the output of ar through sed and get rid of the time field (simple but somewhat destructive) or to get rid of either the time field or the year field based on the current year... Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Wed Mar 8 23:23:04 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 00:23:04 +0100 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> Message-ID: <1141860184.2629.8.camel@athlon> Hi Pavel, On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: > 2005 control.tar.gz It appears ar is the app which uses 4 field dates that I was looking for ;-s . Please try the following patch against vfs/extfs/uar. It removes the fourth date field from the ls output. Since it is impossible to distinguish between 3 and 4 field dates and the implementation of a separate path for 3 and 4 field dates is not trivial the approach should always be to strip down 4 field dates to 3 fields. Leonard. -- mount -t life -o ro /dev/dna /genetic/research -------------- next part -------------- A non-text attachment was scrubbed... Name: uar.diff Type: text/x-patch Size: 445 bytes Desc: not available URL: From savannah-bounces at gnu.org Thu Mar 9 00:15:02 2006 From: savannah-bounces at gnu.org (Thomas Zajic) Date: Thu, 9 Mar 2006 01:15:02 +0100 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060308-170204.sv36205.85604@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> <20060308-170047.sv36205.6244@savannah.gnu.org> <20060308-170204.sv36205.85604@savannah.gnu.org> Message-ID: <20060309-011502.sv14402.28237@savannah.gnu.org> Follow-up Comment #11, bug #13101 (project mc): Yes, both moving and copying a single file works fine now (latest CVS with the attached patch applied), even with ftpfs_first_cd_then_ls=0. Again, thanks a lot! :-) _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From ptsekov at gmx.net Thu Mar 9 08:45:57 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 10:45:57 +0200 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: <1141860184.2629.8.camel@athlon> References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> Message-ID: On Thu, 9 Mar 2006, Leonard den Ottolander wrote: > On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: > > 2005 control.tar.gz > > It appears ar is the app which uses 4 field dates that I was looking > for ;-s . Please try the following patch against vfs/extfs/uar. It > removes the fourth date field from the ls output. The patch behaves well on Linux (with GNU tools), but not on Solaris for example. + thisyear="$(date +%Y)" This should be changed to: thisyear="`date +%Y`" Why is this necessary: + $XAR tv "$1" | sed 's,^,-,;s, , 1 ,;s,/, ,' | sed -e "s/\(.\?\)\([0-2][0-9]\:[0-5][0-9] \)\(${thisyear} \)\(.*\)/\1\2\4/" | sed -e "s/\(.\?\)\([0-2][0-9]\:[0-5][0-9] \)\([0-2][0-9][0-9][0-9] \)\(.*\)/\1\3\4/" ^^^^^^^ The \? is GNU extension and I don't really understand why that construct is necessary (I am not a regex guru though) so can you explain ? > Since it is impossible to distinguish between 3 and 4 field dates and > the implementation of a separate path for 3 and 4 field dates is not > trivial the approach should always be to strip down 4 field dates to 3 > fields. I agree. Determining the date format could be achieved but it is not a trivial task and I am not really sure that it is so important after all. From savannah-bounces at gnu.org Thu Mar 9 08:48:55 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 9 Mar 2006 10:48:55 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060309-011502.sv14402.28237@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> <20060308-170047.sv36205.6244@savannah.gnu.org> <20060308-170204.sv36205.85604@savannah.gnu.org> <20060309-011502.sv14402.28237@savannah.gnu.org> Message-ID: <20060309-104855.sv36205.44385@savannah.gnu.org> Follow-up Comment #12, bug #13101 (project mc): I'll wait till 21 March before commiting this patch. That's almost two weeks - I think this is enough time for other developers to comment. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From ptsekov at gmx.net Thu Mar 9 10:27:47 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 12:27:47 +0200 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: <1141860184.2629.8.camel@athlon> References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> Message-ID: On Thu, 9 Mar 2006, Leonard den Ottolander wrote: > On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: > > 2005 control.tar.gz > > It appears ar is the app which uses 4 field dates that I was looking > for ;-s . Please try the following patch against vfs/extfs/uar. It > removes the fourth date field from the ls output. deb extfs is also broken with cvs MC. So I guess it must be fixed too. From jnovy at redhat.com Thu Mar 9 12:48:20 2006 From: jnovy at redhat.com (Jindrich Novy) Date: Thu, 09 Mar 2006 13:48:20 +0100 Subject: Inconsistent behaviour of Options Message-ID: <1141908500.6330.29.camel@localhost.localdomain> Hi mc-devel, there are two types of dialogs in Options menu. The first type contains three buttons: Ok, Save, Cancel and the second only Ok and Cancel. There's a default action in the dialogs with only Ok and Cancel that Ok saves the configuration globally so that it's written to ini file just after finishing the dialog. If you try to configure with "Options/Configuration..." and "Options/Layout..." you see Ok, Save, Cancel. If you press either Ok or Save the settings are written to ini file so that the settings will be set again when new mc is launched and not only for the current session. The question is whether to fix the bug in the way that: 1. "Ok" sets the parameters only for the current session and won't touch the ini file. "Save" saves the configuration to ini file so that it's needed to add the "Save" button to the rest of the Options dialog entries to make it consistent. 2. "Ok" sets the parameters to ini file for all the dialogs, so that it's needed to remove "Save" button from the Layout and Configuration options to make it consistent. What's your opinion? Jindrich From ptsekov at gmx.net Thu Mar 9 12:58:53 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 14:58:53 +0200 Subject: Comments on deb-support-without-dpkg.patch In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> Message-ID: Chan On Mon, 6 Feb 2006, Pavel Tsekov wrote: > > deb-support-without-dpkg.patch > > For systems withoput dpkg (almost any non-debian OS). > > It handles .deb files as regular .ar archives, as they are in reality. > > This would be nice addition. Only if we could avoid the 'O' option of gnu > tar... Does anyone know of a way to avoid it ? In any case I think this > patch is worth adding. This patch although useful has certain drawbacks and I don't think it is ready to replace the use of dpkg as-is. 1) To use the patch one has to install development tools (i.e. binutils). This is not a major problem but it is still annoying - especially for non-developers. 2) "Open=%cd %p#uar" differs in behaviour from "Open=%cd %p#deb" - in my opinion "Open=%cd %p#deb" is better. However, the "deb" script may be modified to use "ar" when it detects that "dpgk" is missing. I think this would be the best thing to do. 3) The View command is highly unportable. Are you willing to improve your patch ? From ptsekov at gmx.net Thu Mar 9 13:14:43 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 15:14:43 +0200 Subject: Inconsistent behaviour of Options In-Reply-To: <1141908500.6330.29.camel@localhost.localdomain> References: <1141908500.6330.29.camel@localhost.localdomain> Message-ID: On Thu, 9 Mar 2006, Jindrich Novy wrote: > there are two types of dialogs in Options menu. The first type contains > three buttons: Ok, Save, Cancel and the second only Ok and Cancel. Good point! This is something I also wanted to put for discussion on the mailing list for some time > The question is whether to fix the bug in the way that: > > 1. "Ok" sets the parameters only for the current session and won't touch > the ini file. "Save" saves the configuration to ini file so that it's > needed to add the "Save" button to the rest of the Options dialog > entries to make it consistent. > > 2. "Ok" sets the parameters to ini file for all the dialogs, so that > it's needed to remove "Save" button from the Layout and Configuration > options to make it consistent. > > What's your opinion? I think solution number 2 is better. After all we have Options -> Save setup so the "Save" buttons are somewhat redundant. There is also the auto_save_setup option which saves the ini file on exit. From ptsekov at gmx.net Thu Mar 9 13:34:49 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 15:34:49 +0200 Subject: select_dirs.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060210142130.81495.qmail@web52707.mail.yahoo.com> Message-ID: On Fri, 10 Feb 2006, Pavel Tsekov wrote: > On Fri, 10 Feb 2006, Arpad Biro wrote: > > > > > /mask things in the current (/) directory > > > > mask/ or /mask/ only directories (path has '/' ending) here > > > > mask files (old behaviour) > > > > > > To me it is not obvious. When I see `/' I think root directory. > > > Anyway, this is just me. What worries me most is the fact that > > > this patch changes the old behaviour. I'd like to hear what other > > > people think of it. > > > > What about using a trailing "//" (double slash) for dir+file? > > It make sense, IMO. And we are not going to change the old behaviour. > Arpi ? How should we proceed with this patch. Shall we alter it as Roland suggested i.e. make the file mask dialog behave as the shell does or change it as per Arpad Biro's suggestion that trailing double slash (//) select everything ? From arpi at thot.banki.hu Thu Mar 9 13:36:32 2006 From: arpi at thot.banki.hu (Arpi) Date: Thu, 9 Mar 2006 14:36:32 +0100 (CET) Subject: Comments on deb-support-without-dpkg.patch In-Reply-To: Message-ID: <20060309133632.DCE5792C87@mail.mplayerhq.hu> Hi, > This patch although useful has certain drawbacks and I don't think it is > ready to replace the use of dpkg as-is. i never thought so. > 1) To use the patch one has to install development tools (i.e. binutils). > This is not a major problem but it is still annoying - especially for > non-developers. > > 2) "Open=%cd %p#uar" differs in behaviour from "Open=%cd %p#deb" - in my > opinion "Open=%cd %p#deb" is better. However, the "deb" script may be > modified to use "ar" when it detects that "dpgk" is missing. I think this > would be the best thing to do. > > 3) The View command is highly unportable. > > Are you willing to improve your patch ? > no, at least not in the near future. it works for me as-is, and i have no time and resources for testing and improving it for other systems. anyway of course it should only be used when dpkg is not available. in that case, it's still far more better than nothing... about the differences to dpkg - i've never seen the #deb thing working, as i dont have debian (or other dpkg-based distros) installed. A'rpi From ptsekov at gmx.net Thu Mar 9 13:57:42 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 9 Mar 2006 15:57:42 +0200 Subject: Comments on deb-support-without-dpkg.patch In-Reply-To: <20060309133632.DCE5792C87@mail.mplayerhq.hu> References: <20060309133632.DCE5792C87@mail.mplayerhq.hu> Message-ID: On Thu, 9 Mar 2006, Arpi wrote: > > This patch although useful has certain drawbacks and I don't think it is > > ready to replace the use of dpkg as-is. > > i never thought so. > > > 1) To use the patch one has to install development tools (i.e. binutils). > > This is not a major problem but it is still annoying - especially for > > non-developers. > > > > 2) "Open=%cd %p#uar" differs in behaviour from "Open=%cd %p#deb" - in my > > opinion "Open=%cd %p#deb" is better. However, the "deb" script may be > > modified to use "ar" when it detects that "dpgk" is missing. I think this > > would be the best thing to do. > > > > 3) The View command is highly unportable. > > > > Are you willing to improve your patch ? > > > > no, at least not in the near future. it works for me as-is, and i have > no time and resources for testing and improving it for other systems. > anyway of course it should only be used when dpkg is not available. > in that case, it's still far more better than nothing... > about the differences to dpkg - i've never seen the #deb thing working, > as i dont have debian (or other dpkg-based distros) installed. dpkg is freely available for download. I never used it myself but I found it and tested the deb script as well as your patch. As you said above your patch is supposed to kick in if dpkg is not available... The way you implemented it uar is used all the time even if dpkg is present. I might try to implement 2 myself when I have more time - it doesn't seem to be too hard anyway. IMO, this patch is not ready for inclusion in MC. Still I don't think your work is in vain - I never knew that .deb files are just ordinary archives and it is possible to manipulate them trough ar. Based on this knowledge I will try to provide a better .deb handler . From arpi at thot.banki.hu Thu Mar 9 14:00:33 2006 From: arpi at thot.banki.hu (Arpi) Date: Thu, 9 Mar 2006 15:00:33 +0100 (CET) Subject: Comments on deb-support-without-dpkg.patch In-Reply-To: Message-ID: <20060309140033.495BA92EBA@mail.mplayerhq.hu> Hi, > dpkg is freely available for download. I never used it myself but I found > it and tested the deb script as well as your patch. As you said above but i'm lazy... and i'm sitting on macosx, not linux... (dunno if dpkg is available for osx, maybe yes, but dunno) > your patch is supposed to kick in if dpkg is not available... The way you > implemented it uar is used all the time even if dpkg is present. i know. it as just a quick dirty hack, and a proof-of-concept that dpkg is not required to open/extract deb archives (just like cpio is enough for rpm files) > I might try to implement 2 myself when I have more time - it doesn't seem > to be too hard anyway. > > IMO, this patch is not ready for inclusion in MC. Still I don't think your > work is in vain - I never knew that .deb files are just ordinary archives > and it is possible to manipulate them trough ar. Based on this knowledge I > will try to provide a better .deb handler . ok, thanks A'rpi From savannah-bounces at gnu.org Thu Mar 9 14:16:02 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 9 Mar 2006 16:16:02 +0200 Subject: [bug #16029] MC doesn't open if network gateway inaccessible. In-Reply-To: <20060307-223148.sv41304.24776@savannah.gnu.org> References: <20060307-205539.sv47834.77141@savannah.gnu.org> <20060307-223148.sv41304.24776@savannah.gnu.org> Message-ID: <20060309-161602.sv36205.54815@savannah.gnu.org> Update of bug #16029 (project mc): Status: None => Need Info _______________________________________________________ Follow-up Comment #2: I couldn't reproduce on FC3 with latest cvs version. Would you mind providing a strace of MC hanging ? You could do so by issuing the following command: strace -o /tmp/mc.strace /usr/bin/mc Replace /usr/bin/mc with the full path to the mc binary. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From jnovy at redhat.com Thu Mar 9 15:03:30 2006 From: jnovy at redhat.com (Jindrich Novy) Date: Thu, 09 Mar 2006 16:03:30 +0100 Subject: Inconsistent behaviour of Options In-Reply-To: References: <1141908500.6330.29.camel@localhost.localdomain> Message-ID: <1141916610.6330.44.camel@localhost.localdomain> Hello Pavel, On Thu, 2006-03-09 at 15:14 +0200, Pavel Tsekov wrote: > > The question is whether to fix the bug in the way that: > > > > 1. "Ok" sets the parameters only for the current session and won't touch > > the ini file. "Save" saves the configuration to ini file so that it's > > needed to add the "Save" button to the rest of the Options dialog > > entries to make it consistent. > > > > 2. "Ok" sets the parameters to ini file for all the dialogs, so that > > it's needed to remove "Save" button from the Layout and Configuration > > options to make it consistent. > > > > What's your opinion? > > I think solution number 2 is better. After all we have Options -> Save > setup so the "Save" buttons are somewhat redundant. There is also the > auto_save_setup option which saves the ini file on exit. I also prefer this solution as the implementation of the Save button is kind of strange because the Save button is handled by B_EXIT action in init_layout() and layout_cmd() and is rather useless in general ;-) Jindrich From leonard at den.ottolander.nl Thu Mar 9 20:47:07 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 21:47:07 +0100 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> Message-ID: <1141937227.2532.6.camel@athlon> On Thu, 2006-03-09 at 12:27 +0200, Pavel Tsekov wrote: > deb extfs is also broken with cvs MC. So I guess it must be fixed too. Ok, I'll look into it. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Thu Mar 9 21:00:20 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 22:00:20 +0100 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> Message-ID: <1141938020.2532.21.camel@athlon> Hi Pavel, On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: > thisyear="`date +%Y`" I assumed the $(command) was portable. If not I need to restore the backticks in mc.wrapper.sh as well. > The \? is GNU extension and I don't really understand why that construct > is necessary (I am not a regex guru though) so can you explain ? The .* matches greedily, so a file name containing a time would be matched instead of the actual time. This is why I used the '?'. Is there a non GNU equivalent for a non greedy match? I'm no regex guru either, so input on how to do this better is appreciated. By the way, instead of a pipe the second expression should only be used if the first didn't match. The current construct strips the year of a file with a name that starts with a year and has a date in this year (i.e. "01:23 2006 2005 bla"). > I agree. Determining the date format could be achieved but it is not a > trivial task and I am not really sure that it is so important after all. I'll document the fact that dates being passed to vfs_parse_ls_lga() need to be parsed back to 3 fields. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Thu Mar 9 21:06:51 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 22:06:51 +0100 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> Message-ID: <1141938411.2532.22.camel@athlon> Hi Pavel, On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: > The \? is GNU extension Is it? Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Thu Mar 9 22:14:59 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 23:14:59 +0100 Subject: Inconsistent behaviour of Options In-Reply-To: <1141908500.6330.29.camel@localhost.localdomain> References: <1141908500.6330.29.camel@localhost.localdomain> Message-ID: <1141942499.2532.32.camel@athlon> Hi Jindrich, On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > 1. "Ok" sets the parameters only for the current session and won't touch > the ini file. "Ok" is equivalent to "save" if "auto save setup" is set. If "auto save setup" is unset "ok" and "save" do differ in their behaviour. This actually *is* consistent. As I hardly change options I had sort of forgotten about the auto save behaviour and I'm afraid I might have confused you because of that :) . > 2. "Ok" sets the parameters to ini file for all the dialogs, so that > it's needed to remove "Save" button from the Layout and Configuration > options to make it consistent. Actually I think we miss a "save" button in the confirmation dialog :-) . I assume the global "save setup" saves the settings for all these sections. I don't think we should drop the "fine grained" save buttons in the other dialogs. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From proski at gnu.org Thu Mar 9 22:31:27 2006 From: proski at gnu.org (Pavel Roskin) Date: Thu, 09 Mar 2006 17:31:27 -0500 Subject: Inconsistent behaviour of Options In-Reply-To: <1141942499.2532.32.camel@athlon> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> Message-ID: <1141943487.2189.5.camel@dv> Hello! On Thu, 2006-03-09 at 23:14 +0100, Leonard den Ottolander wrote: > Hi Jindrich, > > On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > > 1. "Ok" sets the parameters only for the current session and won't touch > > the ini file. > > "Ok" is equivalent to "save" if "auto save setup" is set. ... and if you exit from mc rather than e.g. close the xterm window. And if you don't have another mc running that would overwrite those settings if you exit from it properly. I think that "auto save setup" is something that cannot be implemented reliably in mc unless you make "Ok" work exactly like "Save" and save changes immediately. -- Regards, Pavel Roskin From leonard at den.ottolander.nl Thu Mar 9 22:40:57 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Thu, 09 Mar 2006 23:40:57 +0100 Subject: Inconsistent behaviour of Options In-Reply-To: <1141943487.2189.5.camel@dv> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> Message-ID: <1141944057.2532.43.camel@athlon> Hello Pavel, On Thu, 2006-03-09 at 17:31 -0500, Pavel Roskin wrote: > ... and if you exit from mc rather than e.g. close the xterm window. > And if you don't have another mc running that would overwrite those > settings if you exit from it properly. The latter would still be a problem with direct saves. And that "auto save setup" only works on normal programme termination should be obvious. > I think that "auto save setup" is something that cannot be implemented > reliably in mc unless you make "Ok" work exactly like "Save" and save > changes immediately. But then the option auto save setup would be redundant... Unless you mean that the behaviour of "Ok" should be changed based on the current "auto save" setting. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From proski at gnu.org Thu Mar 9 23:33:31 2006 From: proski at gnu.org (Pavel Roskin) Date: Thu, 09 Mar 2006 18:33:31 -0500 Subject: Inconsistent behaviour of Options In-Reply-To: <1141944057.2532.43.camel@athlon> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> <1141944057.2532.43.camel@athlon> Message-ID: <1141947211.2189.27.camel@dv> On Thu, 2006-03-09 at 23:40 +0100, Leonard den Ottolander wrote: > Hello Pavel, > > On Thu, 2006-03-09 at 17:31 -0500, Pavel Roskin wrote: > > ... and if you exit from mc rather than e.g. close the xterm window. > > And if you don't have another mc running that would overwrite those > > settings if you exit from it properly. > > The latter would still be a problem with direct saves. I don't understand which scenario you have in mind. If you mean saving settings from two mc instances, that would be a problem, but it's a counter-intuitive thing for users to do. > And that "auto > save setup" only works on normal programme termination should be > obvious. Remember, users can be distracted, and they are generally assumed to have a short attention span. You cannot expect a user to remember to exit from mc correctly to save settings. There may be thousands of things between changing the configuration and ending mc, and some of them can kill mc, e.g. as X crash due to some other software, closing a wrong window, reboot due to urgent security upgrade etc. I actually find it more natural that once the dialog has been dismissed by any button, I don't have to remember to do anything. I'm accustomed to software that doesn't use my memory too much. Also, programs that save anything on exit try to protect against killing until that data has been saved. That's why SIGKILL is the last resort. mc doesn't do anything like that, as it would lose the unsaved configuration even on SIGHUP. > > I think that "auto save setup" is something that cannot be implemented > > reliably in mc unless you make "Ok" work exactly like "Save" and save > > changes immediately. > > But then the option auto save setup would be redundant... Unless you > mean that the behaviour of "Ok" should be changed based on the current > "auto save" setting. I think "auto save setup" is redundant, but I never had time to remove it. Besides, it would open a huge can of worms. Some users rely on "auto save setup" to have mc remember the last directories. Sure, such users have a different mental model of mc, they try not to kill mc, and I guess they run one copy of mc at most (so it's more a DOS/Norton Commander like model). Another group of users likes to edit configuration files manually. If mc defaults not to save the configuration, the configuration files are not created first time mc is run. Somebody would complain. -- Regards, Pavel Roskin From ossi at kde.org Fri Mar 10 06:46:45 2006 From: ossi at kde.org (Oswald Buddenhagen) Date: Fri, 10 Mar 2006 07:46:45 +0100 Subject: Inconsistent behaviour of Options In-Reply-To: <1141943487.2189.5.camel@dv> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> Message-ID: <20060310064645.GA5169@ugly.local> On Thu, Mar 09, 2006 at 05:31:27PM -0500, Pavel Roskin wrote: > On Thu, 2006-03-09 at 23:14 +0100, Leonard den Ottolander wrote: > > On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > > > 1. "Ok" sets the parameters only for the current session and won't > > > touch the ini file. > > > > "Ok" is equivalent to "save" if "auto save setup" is set. > > ... and if you exit from mc rather than e.g. close the xterm window. > just closing xterm is generally a stupid idea. and forgetting it at session exit ... my wish for supporting xsmp still stands. > And if you don't have another mc running that would overwrite those > settings if you exit from it properly. > KConfig rescans the config and merges the changes into the just read config on saving. i think it wouldn't be that hard to implement in mc, too. of course this doesn't help with conflicting changes, but that's obvious and part of the "mental model". > I think that "auto save setup" is something that cannot be implemented > reliably in mc unless you make "Ok" work exactly like "Save" and save > changes immediately. > this is what both kde and gnome do, so i think it's safe to assume it is a reasonable approach. as far as remembering the last directory is concerned: that's sort of poor man's session management, not option management. it's basically the same as remembering the last position in the viewer and editor. i.e., there should be a separate option for enabling it. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. From ptsekov at gmx.net Fri Mar 10 08:34:42 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 10 Mar 2006 10:34:42 +0200 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: <1141938020.2532.21.camel@athlon> References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> <1141938020.2532.21.camel@athlon> Message-ID: On Thu, 9 Mar 2006, Leonard den Ottolander wrote: > On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: > > thisyear="`date +%Y`" > > I assumed the $(command) was portable. If not I need to restore the > backticks in mc.wrapper.sh as well. The `...` is referred as the historical syntax in all sources that I managed to find. The $(...) is the new and improved syntax. As long as we use /bin/sh I think we should not assume that it is capable of the new syntax. $ uname -a SunOS sole 5.10 Generic_118822-11 sun4u sparc SUNW,Sun-Blade-1000 $ thisyear="$(date +%Y)" $ echo $thisyear $(date +%Y) > > The \? is GNU extension and I don't really understand why that construct > > is necessary (I am not a regex guru though) so can you explain ? > > The .* matches greedily, so a file name containing a time would be > matched instead of the actual time. This is why I used the '?'. Is there > a non GNU equivalent for a non greedy match? As far as I understand .\? will match a single char (any char) or no char at all so if we have (output of "ar tv"): -rw-r--r-- 1 0 0 4 Oct 16 18:30 2005 debian-binary so with your regex \(.\?\) matches the space character between 16 and 18:30. I don't see how this help with regard to the problem you are describing above ?! From ptsekov at gmx.net Fri Mar 10 08:43:46 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 10 Mar 2006 10:43:46 +0200 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: <1141938411.2532.22.camel@athlon> References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> <1141938411.2532.22.camel@athlon> Message-ID: On Thu, 9 Mar 2006, Leonard den Ottolander wrote: > On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: > > The \? is GNU extension > > Is it? >From the GNU sed info manual: `\?' As `*', but only matches zero or one. It is a GNU extension. From ptsekov at gmx.net Fri Mar 10 08:59:25 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 10 Mar 2006 10:59:25 +0200 Subject: Inconsistent behaviour of Options In-Reply-To: <1141943487.2189.5.camel@dv> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> Message-ID: On Thu, 9 Mar 2006, Pavel Roskin wrote: > On Thu, 2006-03-09 at 23:14 +0100, Leonard den Ottolander wrote: > > Hi Jindrich, > > > > On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > > > 1. "Ok" sets the parameters only for the current session and won't touch > > > the ini file. > > > > "Ok" is equivalent to "save" if "auto save setup" is set. > > ... and if you exit from mc rather than e.g. close the xterm window. > And if you don't have another mc running that would overwrite those > settings if you exit from it properly. > > I think that "auto save setup" is something that cannot be implemented > reliably in mc unless you make "Ok" work exactly like "Save" and save > changes immediately. I think this is a reasonable approch. If we go that way we can safely remove "Save setup" and auto_save_setup. From ptsekov at gmx.net Fri Mar 10 09:07:17 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 10 Mar 2006 11:07:17 +0200 Subject: Inconsistent behaviour of Options In-Reply-To: <1141942499.2532.32.camel@athlon> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> Message-ID: On Thu, 9 Mar 2006, Leonard den Ottolander wrote: > > 2. "Ok" sets the parameters to ini file for all the dialogs, so that > > it's needed to remove "Save" button from the Layout and Configuration > > options to make it consistent. > > Actually I think we miss a "save" button in the confirmation > dialog :-) . I assume the global "save setup" saves the settings for all > these sections. I don't think we should drop the "fine grained" save > buttons in the other dialogs. There is no such thing as "finer grained" saving - every sections is saved by the "Save" buttons. From ptsekov at gmx.net Fri Mar 10 11:59:04 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 10 Mar 2006 13:59:04 +0200 Subject: Inconsistent behaviour of Options In-Reply-To: <20060310100923.12e63e59@localhost.localdomain> References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> <20060310100923.12e63e59@localhost.localdomain> Message-ID: On Fri, 10 Mar 2006, wwp wrote: > Hello Pavel, > > > On Fri, 10 Mar 2006 10:59:25 +0200 Pavel Tsekov wrote: > > > On Thu, 9 Mar 2006, Pavel Roskin wrote: > > > > > On Thu, 2006-03-09 at 23:14 +0100, Leonard den Ottolander wrote: > > > > Hi Jindrich, > > > > > > > > On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > > > > > 1. "Ok" sets the parameters only for the current session and won't > > > > > touch the ini file. > > > > > > > > "Ok" is equivalent to "save" if "auto save setup" is set. > > > > > > ... and if you exit from mc rather than e.g. close the xterm window. > > > And if you don't have another mc running that would overwrite those > > > settings if you exit from it properly. > > > > > > I think that "auto save setup" is something that cannot be implemented > > > reliably in mc unless you make "Ok" work exactly like "Save" and save > > > changes immediately. > > > > I think this is a reasonable approch. If we go that way we can safely > > remove "Save setup" and auto_save_setup. > > That means that you would not be able to modify some options w/o saving them > (and thus, affect all further instances)? Hmm... This is a strong indication that those options do not belong to the Options menu, IMO. From czernikp at pit.edu.pl Fri Mar 10 09:38:03 2006 From: czernikp at pit.edu.pl (Piotr Czernik) Date: Fri, 10 Mar 2006 10:38:03 +0100 Subject: Display issue midnight commander Message-ID: <441148FB.1060701@pit.edu.pl> mc 4.6.0 on Linux Mandrake 10.0 2.6.3-7mdk In directory tree top (..) have date of other (not current) directory. From subscript at free.fr Sat Mar 11 10:44:08 2006 From: subscript at free.fr (wwp) Date: Sat, 11 Mar 2006 11:44:08 +0100 Subject: Inconsistent behaviour of Options In-Reply-To: References: <1141908500.6330.29.camel@localhost.localdomain> <1141942499.2532.32.camel@athlon> <1141943487.2189.5.camel@dv> <20060310100923.12e63e59@localhost.localdomain> Message-ID: <20060311114408.37dd592a@localhost.localdomain> Hello Pavel, On Fri, 10 Mar 2006 13:59:04 +0200 Pavel Tsekov wrote: > On Fri, 10 Mar 2006, wwp wrote: > > > Hello Pavel, > > > > > > On Fri, 10 Mar 2006 10:59:25 +0200 Pavel Tsekov wrote: > > > > > On Thu, 9 Mar 2006, Pavel Roskin wrote: > > > > > > > On Thu, 2006-03-09 at 23:14 +0100, Leonard den Ottolander wrote: > > > > > Hi Jindrich, > > > > > > > > > > On Thu, 2006-03-09 at 13:48 +0100, Jindrich Novy wrote: > > > > > > 1. "Ok" sets the parameters only for the current session and won't > > > > > > touch the ini file. > > > > > > > > > > "Ok" is equivalent to "save" if "auto save setup" is set. > > > > > > > > ... and if you exit from mc rather than e.g. close the xterm window. > > > > And if you don't have another mc running that would overwrite those > > > > settings if you exit from it properly. > > > > > > > > I think that "auto save setup" is something that cannot be implemented > > > > reliably in mc unless you make "Ok" work exactly like "Save" and save > > > > changes immediately. > > > > > > I think this is a reasonable approch. If we go that way we can safely > > > remove "Save setup" and auto_save_setup. > > > > That means that you would not be able to modify some options w/o saving > > them (and thus, affect all further instances)? > > Hmm... This is a strong indication that those options do not belong to the > Options menu, IMO. If I'm not wrong there are options set outside from the Options menu/dialogs that get saved, like user mini status in listing mode, I didn't feel uncomfortable w/ that. Anyway, maybe the simple way would be the best, and would be smth like only keeping a "Save options" menu entry that users must explicitely use. I must admit that I'm a little bit lost now in the discussion.. ;-) Regards, -- wwp -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available URL: From leonard at den.ottolander.nl Sat Mar 11 21:18:46 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Sat, 11 Mar 2006 22:18:46 +0100 Subject: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz In-Reply-To: References: <20060204235309.927158F56A@mail.mplayerhq.hu> <1141860184.2629.8.camel@athlon> <1141938020.2532.21.camel@athlon> Message-ID: <1142111927.2630.11.camel@athlon> Hi Pavel, On Fri, 2006-03-10 at 10:34 +0200, Pavel Tsekov wrote: > As far as I understand .\? will match a single char (any char) or no char > at all so if we have (output of "ar tv"): You are right. What I was trying to achieve is to explicitly match the first part of the string without being greedy (in case the file name contains a time string). I'm not sure how to achieve that. But since the first part of the string is unaffected by the matching anyway the first match can just be dropped. See attached patch for how I propose to avoid a double match in the two expressions if the filename contains a time or date value by temporarily introducing a unique separator string. Leonard. -- mount -t life -o ro /dev/dna /genetic/research -------------- next part -------------- A non-text attachment was scrubbed... Name: uar.diff Type: text/x-patch Size: 605 bytes Desc: not available URL: From leonard at den.ottolander.nl Sat Mar 11 21:39:04 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Sat, 11 Mar 2006 22:39:04 +0100 Subject: [PATCH] Update file system and mount info in acinclude.m4 In-Reply-To: <1138811352.2485.7.camel@athlon> References: <1138811352.2485.7.camel@athlon> Message-ID: <1142113144.2630.12.camel@athlon> Hi, On Wed, 2006-02-01 at 17:29 +0100, Leonard den Ottolander wrote: > Although this patch doesn't fix any current issue it might be still a > good a idea to update the code in acinclude.m4 that acquires the file > system and mount information to a more recent version. > > The original blocks were taken from fileutils-3.12. I've updated these > to the corresponding code from coreutils-5.93. To make the origins more > clear I've also m4_include()d the corresponding files instead of copying > them inline. Any objections against me committing this "normalization"? Leonard. -- mount -t life -o ro /dev/dna /genetic/research From savannah-bounces at gnu.org Sun Mar 12 19:42:48 2006 From: savannah-bounces at gnu.org (Gergely =?UTF-8?B?U3rDoXN6?=) Date: Sun, 12 Mar 2006 19:42:48 +0000 Subject: [patch #4970] add label highlighting to c.syntax Message-ID: <20060312-194248.sv8412.23459@savannah.gnu.org> URL: Summary: add label highlighting to c.syntax Project: GNU Midnight Commander Submitted by: szaszg Submitted on: Sun 03/12/06 at 19:42 Category: Editor Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open _______________________________________________________ Details: This patch add label (goto) highlighting to c.syntax _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Sun 03/12/06 at 19:42 Name: mc.syntax.c.diff Size: 532B By: szaszg label highlighting _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 15 16:10:58 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 15 Mar 2006 18:10:58 +0200 Subject: [bug #13673] `mcedit /some/file' doesn't create a lock file In-Reply-To: <20050707-142143.sv36205.96314@savannah.gnu.org> References: <20050707-134314.sv36205.40117@savannah.gnu.org> <20050707-142143.sv36205.96314@savannah.gnu.org> Message-ID: <20060315-181058.sv36205.41907@savannah.gnu.org> Update of bug #13673 (project mc): Status: None => Fixed Assigned to: None => ptsekov Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #2: I've just commited a fix: http://cvs.savannah.gnu.org/viewcvs/mc/edit/editlock.c?root=mc&sortby=date&r2=1.15&r1=1.14&diff_format=u _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 15 16:30:30 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 15 Mar 2006 18:30:30 +0200 Subject: [patch #3204] Perl pod files in mc.ext.in Message-ID: <20060315-183030.sv36205.88320@savannah.gnu.org> Update of patch #3204 (project mc): Category: None => VFS Status: None => Done Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #1: I've commited a slightly modified version of your original patch: http://cvs.savannah.gnu.org/viewcvs/mc/lib/mc.ext.in?root=mc&sortby=date&r2=1.85&r1=1.84&diff_format=u I changed your patch to use $PAGER instead of sensible-pager. Thanks! _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From vadim-lvv at yandex.ru Thu Mar 16 10:09:20 2006 From: vadim-lvv at yandex.ru (vadim) Date: Thu, 16 Mar 2006 12:09:20 +0200 Subject: [patch] support xclipboard Message-ID: <200603161209.20721.vadim-lvv@yandex.ru> Patch for support XCLIPBOARD from mc. It can work in 2 way: - using Xlib if mc compile with-x - using external program if mc compile without-x External program is xclip ( http://people.debian.org/~kims/xclip/ ) and qtclipb ( attached file or http://www.klv.lg.ua/~vadim/ ). qtclipb be writed for work with KDE since xclip can not insert into XCLIPBOARD under KDE. -- vadim -------------- next part -------------- A non-text attachment was scrubbed... Name: mc-4.6.1-xclip.patch.bz2 Type: application/x-bzip2 Size: 7808 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: qtclipb-0.01.tar.bz2 Type: application/x-tbz Size: 10550 bytes Desc: not available URL: From ossi at kde.org Thu Mar 16 12:50:03 2006 From: ossi at kde.org (Oswald Buddenhagen) Date: Thu, 16 Mar 2006 13:50:03 +0100 Subject: [patch] support xclipboard In-Reply-To: <200603161209.20721.vadim-lvv@yandex.ru> References: <200603161209.20721.vadim-lvv@yandex.ru> Message-ID: <20060316125003.GA7070@ugly.local> On Thu, Mar 16, 2006 at 12:09:20PM +0200, vadim wrote: > Patch for support XCLIPBOARD from mc. > cool. > xclip can not insert into XCLIPBOARD under KDE. > try disabling klipper and/or playing with its options. as an option, your code should be able to use PRIMARY instead of CLIPBOARD - that should help with some klipper configurations and sounds like a desirable option in general. your code uses array(s) with variable dimensions, afaics - that's not portable. if mc already uses alloca, that's the way to go. otherwise only malloc or statically sized arrays are left. keep whitespace changes out of your patches. ps: pavel, maybe just run perl -pi -e 's,[ \t]+$,,' `find -type f` over the repo and commit it. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. From ptsekov at gmx.net Thu Mar 16 16:07:59 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 16 Mar 2006 17:07:59 +0100 (MET) Subject: [patch] support xclipboard References: <200603161209.20721.vadim-lvv@yandex.ru> Message-ID: <17795.1142525279@www098.gmx.net> > Patch for support XCLIPBOARD from mc. > It can work in 2 way: > - using Xlib if mc compile with-x > - using external program if mc compile without-x > External program is xclip ( http://people.debian.org/~kims/xclip/ ) and > qtclipb ( attached file or http://www.klv.lg.ua/~vadim/ ). > qtclipb be writed for work with KDE since xclip can not insert into > XCLIPBOARD under KDE. I'll try to review this patch in the next few days. In any case I'll split it in 2 or 3 (Xlib and non-Xlib variants) parts and I'll commit/review them separately. -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer From vadim-lvv at yandex.ru Thu Mar 16 16:51:45 2006 From: vadim-lvv at yandex.ru (vadim-lvv at yandex.ru) Date: Thu, 16 Mar 2006 19:51:45 +0300 (MSK) Subject: [patch] support xclipboard In-Reply-To: <17795.1142525279@www098.gmx.net> References: <200603161209.20721.vadim-lvv@yandex.ru> <17795.1142525279@www098.gmx.net> Message-ID: <441997A1.000002.29252@soapbox.yandex.ru> >I'll try to review this patch in the next few days. In any case I'll split >it in 2 or 3 (Xlib and non-Xlib variants) parts and I'll commit/review them >separately. But why do you want to split it? why not #if #else #endif ? ps I use this patch for a half of a year. pps ???????? ???????? ?????? ??? ?????? ? xlib - ???? ?? ???????? ?????????? ? ??????, ??? ?? ????????? ???????????? ???? ? ??? ?? display, ?? ??? ?????? ? ??? ?????? ? ????? ?? ????????, ?.? ???????? ???? ?? ???????, ??? ? ? xclip ? ??-?? ??????? ? ??????? ?????? ?????? ? qt. ????? ?? ???? ??????? ???? ????????, ????? ? ???? ?????? ????? - ? ??? ????????? ? gtk ? ????? ??? ????? ??? ??? ?????? ???. ???? ?????? ?????? xlib - ??????. -- Vadim Likhota From vadim-lvv at yandex.ru Thu Mar 16 17:54:57 2006 From: vadim-lvv at yandex.ru (vadim-lvv at yandex.ru) Date: Thu, 16 Mar 2006 20:54:57 +0300 (MSK) Subject: (no subject) Message-ID: <4419A671.000002.17107@camay.yandex.ru> > > xclip can not insert into XCLIPBOARD under KDE. > > > try disabling klipper and/or playing with its options. I allways have running klipper. > as an option, your code should be able to use PRIMARY instead of > CLIPBOARD - that should help with some klipper configurations and sounds > like a desirable option in general. for me PRIMARY not need, but it will can add only as yet parameter in get_xclip()/set_xclip() -- Vadim Likhota From jnovy at redhat.com Thu Mar 16 18:19:27 2006 From: jnovy at redhat.com (Jindrich Novy) Date: Thu, 16 Mar 2006 19:19:27 +0100 Subject: [patch] support xclipboard In-Reply-To: <200603161209.20721.vadim-lvv@yandex.ru> References: <200603161209.20721.vadim-lvv@yandex.ru> Message-ID: <1142533167.3141.26.camel@localhost.localdomain> Hi Vadim, On Thu, 2006-03-16 at 12:09 +0200, vadim wrote: > Patch for support XCLIPBOARD from mc. > It can work in 2 way: > - using Xlib if mc compile with-x > - using external program if mc compile without-x > External program is xclip ( http://people.debian.org/~kims/xclip/ ) and qtclipb ( attached file or http://www.klv.lg.ua/~vadim/ ). > qtclipb be writed for work with KDE since xclip can not insert into XCLIPBOARD under KDE. I like the idea, but I have a few comments related to the patch: 1) sprintf(mc_cl_file, "%s/.mc/%s", home_dir, XCLIPB_FILE); Please use snprintf instead to prevent buffer overflows. If the patch is commited as-is the long home_dir may cause overwriting of en_xcl what causes unintentional change of functionality of your patch because mc_cl_file is declared like: +static char mc_cl_file [256]; +//static FILE *fl = NULL; +static int en_xcl = 0; /* 1 -> enable xclipboard , -1 -> found kde */ 2) + //if ( start >= finish ) { + /* for ( ; i < finish ; i++ ) { + buff[i - start] = edit_get_byte (edit, i); + }*/ + buff = edit_get_block (edit, start, finish, &len); + //} Please avoid putting a commented out code in the patch, this only confuses the reviewer as well as these useless hunks: @@ -2366,7 +2438,7 @@ exp = old ? old : ""; - exp = input_dialog (_(" Run Sort "), + exp = input_dialog (_(" Run Sort "), _(" Enter sort options (see manpage) separated by whitespace: "), exp); if (!exp) Thanks, Jindrich From savannah-bounces at gnu.org Fri Mar 17 14:06:30 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Fri, 17 Mar 2006 16:06:30 +0200 Subject: [patch #4162] detach on quick-save In-Reply-To: <20050711-214332.sv41304.20825@savannah.gnu.org> References: <20050711-214332.sv41304.20825@savannah.gnu.org> Message-ID: <20060317-160630.sv36205.24003@savannah.gnu.org> Update of patch #4162 (project mc): Category: None => Editor Status: None => In Progress Assigned to: None => ptsekov _______________________________________________________ Follow-up Comment #1: Oswald, I've reviewed your patch and changed it a bit. The hunk that delt with unlocking both the modify and the save locks is already in CVS. I've changed the rest of the patch mainly cosmetically (rearranged the code a bit, formating, etc) but there is one _important_ (IMO) change - I changed the code to stat the destination filename to determine whether it has hardlinks . There are several reasons to do so - the most obvious one being editing a hardlinked file an using Save As to save it under a new name which is not hardlinked. I am attaching the modified patch so that you can test/review it. I'll wait for your comments before I commit this patch. _______________________________________________________ Additional Item Attachment: File name: mc-detach-update.patch Size:3 KB _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 15:02:14 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Fri, 17 Mar 2006 17:02:14 +0200 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060312-194248.sv8412.23459@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> Message-ID: <20060317-170214.sv36205.75631@savannah.gnu.org> Follow-up Comment #1, patch #4970 (project mc): Any comments from the syntax gurus ? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 15:03:44 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Fri, 17 Mar 2006 16:03:44 +0100 Subject: [patch #4162] detach on quick-save In-Reply-To: <20060317-160630.sv36205.24003@savannah.gnu.org> References: <20050711-214332.sv41304.20825@savannah.gnu.org> <20060317-160630.sv36205.24003@savannah.gnu.org> Message-ID: <20060317-160343.sv41304.51357@savannah.gnu.org> Follow-up Comment #2, patch #4162 (project mc): you put the mc_close() outside an else branch; you'll now close an arbitrary handle if the file is not local; closing -1 is not too nice, either. other than that it looks ok. btw, edit_save_as_cmd() uses mc_open() to "fake" an mc_stat() - i think it would make sense to change it. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 15:13:52 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Fri, 17 Mar 2006 16:13:52 +0100 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060317-170214.sv36205.75631@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> Message-ID: <20060317-161352.sv41304.82068@savannah.gnu.org> Follow-up Comment #2, patch #4970 (project mc): my labels are all unindented by half an indentation step (or one tab back, two spaces forward), so i don't need additional coloring. also, the color has less contrast, so i'm not terribly thrilled. but other than that i could not care less ... _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 15:14:57 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Fri, 17 Mar 2006 17:14:57 +0200 Subject: [patch #4162] detach on quick-save In-Reply-To: <20060317-160343.sv41304.51357@savannah.gnu.org> References: <20050711-214332.sv41304.20825@savannah.gnu.org> <20060317-160630.sv36205.24003@savannah.gnu.org> <20060317-160343.sv41304.51357@savannah.gnu.org> Message-ID: <20060317-171457.sv36205.55836@savannah.gnu.org> Follow-up Comment #3, patch #4162 (project mc): Right! My bad. The logic was pretty twisted anyway. I'll fix the patch and commit it. I also noted that mc_open() is used to emulate stat() on at least one more place but I didn't want to change it since I might miss something . _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 15:43:44 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Fri, 17 Mar 2006 17:43:44 +0200 Subject: [patch #4162] detach on quick-save In-Reply-To: <20060317-171457.sv36205.55836@savannah.gnu.org> References: <20050711-214332.sv41304.20825@savannah.gnu.org> <20060317-160630.sv36205.24003@savannah.gnu.org> <20060317-160343.sv41304.51357@savannah.gnu.org> <20060317-171457.sv36205.55836@savannah.gnu.org> Message-ID: <20060317-174344.sv36205.75080@savannah.gnu.org> Update of patch #4162 (project mc): Status: In Progress => Done Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #4: I've commited the patch. Thanks! _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Fri Mar 17 20:13:25 2006 From: savannah-bounces at gnu.org (Oswald Buddenhagen) Date: Fri, 17 Mar 2006 21:13:25 +0100 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060317-161352.sv41304.82068@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> Message-ID: <20060317-211325.sv41304.63756@savannah.gnu.org> Follow-up Comment #3, patch #4970 (project mc): actually, this patch sucks - it breaks the highlighting of the default: labels in switch statements. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Sat Mar 18 10:08:49 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Sat, 18 Mar 2006 12:08:49 +0200 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060317-211325.sv41304.63756@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> <20060317-211325.sv41304.63756@savannah.gnu.org> Message-ID: <20060318-120849.sv36205.36817@savannah.gnu.org> Follow-up Comment #4, patch #4970 (project mc): Ok. So, it should be fixed. Gergely ? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Sat Mar 18 13:40:32 2006 From: savannah-bounces at gnu.org (Leonard den Ottolander) Date: Sat, 18 Mar 2006 14:40:32 +0100 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060318-120849.sv36205.36817@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> <20060317-211325.sv41304.63756@savannah.gnu.org> <20060318-120849.sv36205.36817@savannah.gnu.org> Message-ID: <20060318-144031.sv26390.61472@savannah.gnu.org> Follow-up Comment #5, patch #4970 (project mc): Fixing this would require to distinguish between contexts or a negative match as in "!default" which I'm not aware of (not saying it isn't implemented). Even adding an extra colon to the "default" keyword doesn't fix the issue, because the added white space makes the regex an earlier match (in cases where "default" doesn't start at the beginning of the line). _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Sun Mar 19 09:09:24 2006 From: savannah-bounces at gnu.org (Gergely =?UTF-8?B?U3rDoXN6?=) Date: Sun, 19 Mar 2006 09:09:24 +0000 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060318-144031.sv26390.61472@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> <20060317-211325.sv41304.63756@savannah.gnu.org> <20060318-120849.sv36205.36817@savannah.gnu.org> <20060318-144031.sv26390.61472@savannah.gnu.org> Message-ID: <20060319-090924.sv8412.83221@savannah.gnu.org> Follow-up Comment #6, patch #4970 (project mc): Sorry Oswald, but i have to say: actually, the highlighting code sucks ;-) Ok. if we change the rule to: keyword whole \{A...z\}\[0...z\]: cyan it highlights the case labels and ( ... ? a: b) if 'a' and the colon does not separated. I do not know, why match the 'label' rule first, even the 'default:' rule is earlier in the syntax file..? If I could remember, some time ago... the order of rules cares... or does not? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Sat Mar 18 14:11:13 2006 From: savannah-bounces at gnu.org (Leonard den Ottolander) Date: Sat, 18 Mar 2006 15:11:13 +0100 Subject: [bug #11951] [RFE] Show size of all files in directory In-Reply-To: <20060227-230902.sv26390.60016@savannah.gnu.org> References: <20050212-193230.sv0.79783@savannah.gnu.org> <20050213-003630.sv0.85992@savannah.gnu.org> <20050214-091720.sv38900.32050@savannah.gnu.org> <20050305-131617.sv39447.17288@savannah.gnu.org> <20050419-222827.sv40639.54791@savannah.gnu.org> <20050516-131910.sv26390.32363@savannah.gnu.org> <20060128-095615.sv20990.54976@savannah.gnu.org> <20060227-230902.sv26390.60016@savannah.gnu.org> Message-ID: <20060318-151113.sv26390.89524@savannah.gnu.org> Update of bug #11951 (project mc): Status: Fixed => In Progress _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From zi4 at gmx.de Sun Mar 19 09:47:43 2006 From: zi4 at gmx.de (Stefan) Date: Sun, 19 Mar 2006 10:47:43 +0100 Subject: Creating a DAR plugin for mc Message-ID: <441D28BF.1010002@gmx.de> hi all, since I'm using Dar (DiskARchiver) for daily backups of our company servers, I'm looking for a comfortable way to restore single files or directories. A plugin in MC would be ideal, similar to the TAR support in MC. Can anyone help me with this task? Would it be much work? thanks, Stefan Jansen From savannah-bounces at gnu.org Sun Mar 19 15:46:45 2006 From: savannah-bounces at gnu.org (Leonard den Ottolander) Date: Sun, 19 Mar 2006 16:46:45 +0100 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060319-090924.sv8412.83221@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> <20060317-211325.sv41304.63756@savannah.gnu.org> <20060318-120849.sv36205.36817@savannah.gnu.org> <20060318-144031.sv26390.61472@savannah.gnu.org> <20060319-090924.sv8412.83221@savannah.gnu.org> Message-ID: <20060319-164645.sv26390.22214@savannah.gnu.org> Follow-up Comment #7, patch #4970 (project mc): Gergely, any perceived flaws in the syntax highlighting code are no excuse for creating a faulty patch that obviously doesn't work with the ruleset. Your patch adds an earlier match overriding the matching of the "default" keyword. This has nothing to do with flaws in the code. Anyway, solution might be to add possible whitespace to the "default" keyword. See attached patch. _______________________________________________________ Additional Item Attachment: File name: c.syntax.diff Size:0 KB Add labels without overruling \"default\" keyword. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Sun Mar 19 20:48:23 2006 From: savannah-bounces at gnu.org (Gergely =?UTF-8?B?U3rDoXN6?=) Date: Sun, 19 Mar 2006 20:48:23 +0000 Subject: [patch #4970] add label highlighting to c.syntax In-Reply-To: <20060319-164645.sv26390.22214@savannah.gnu.org> References: <20060312-194248.sv8412.23459@savannah.gnu.org> <20060317-170214.sv36205.75631@savannah.gnu.org> <20060317-161352.sv41304.82068@savannah.gnu.org> <20060317-211325.sv41304.63756@savannah.gnu.org> <20060318-120849.sv36205.36817@savannah.gnu.org> <20060318-144031.sv26390.61472@savannah.gnu.org> <20060319-090924.sv8412.83221@savannah.gnu.org> <20060319-164645.sv26390.22214@savannah.gnu.org> Message-ID: <20060319-204823.sv8412.33015@savannah.gnu.org> Follow-up Comment #8, patch #4970 (project mc): Thanks Leonard :-) Flaws are very beautiful creatures... _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From gjansman1 at hotmail.com Wed Mar 22 13:53:18 2006 From: gjansman1 at hotmail.com (G Jansman) Date: Wed, 22 Mar 2006 14:53:18 +0100 Subject: Creating a DAR plugin for mc Message-ID: Hi Stefan, Attached is a plugin which might be useful. Succes, Guus Jansman >hi all, >since I'm using Dar (DiskARchiver) for daily backups of our company >servers, I'm looking for a comfortable way to restore single files or >directories. A plugin in MC would be ideal, similar to the TAR support in >MC. > >Can anyone help me with this task? Would it be much work? > >thanks, Stefan Jansen -------------- next part -------------- A non-text attachment was scrubbed... Name: extfs_dar.zip Type: application/zip Size: 2380 bytes Desc: not available URL: From savannah-bounces at gnu.org Thu Mar 23 12:37:47 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 23 Mar 2006 14:37:47 +0200 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060309-104855.sv36205.44385@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> <20060308-170047.sv36205.6244@savannah.gnu.org> <20060308-170204.sv36205.85604@savannah.gnu.org> <20060309-011502.sv14402.28237@savannah.gnu.org> <20060309-104855.sv36205.44385@savannah.gnu.org> Message-ID: <20060323-143747.sv36205.37888@savannah.gnu.org> Update of bug #13101 (project mc): Status: In Progress => Fixed Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #13: I've commited the patch. Closing the bugreport as fixed. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 23 12:46:35 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 23 Mar 2006 14:46:35 +0200 Subject: [bug #16029] MC doesn't open if network gateway inaccessible. In-Reply-To: <20060309-161602.sv36205.54815@savannah.gnu.org> References: <20060307-205539.sv47834.77141@savannah.gnu.org> <20060307-223148.sv41304.24776@savannah.gnu.org> <20060309-161602.sv36205.54815@savannah.gnu.org> Message-ID: <20060323-144635.sv36205.80764@savannah.gnu.org> Follow-up Comment #3, bug #16029 (project mc): Ping ? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 23 15:04:46 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 23 Mar 2006 17:04:46 +0200 Subject: [bug #13953] mc doesn't clean up tempfiles In-Reply-To: <20050801-220101.sv26390.12244@savannah.gnu.org> References: <20050727-144049.sv42903.30657@savannah.gnu.org> <20050801-085602.sv36205.68542@savannah.gnu.org> <20050801-220101.sv26390.12244@savannah.gnu.org> Message-ID: <20060323-170446.sv36205.48276@savannah.gnu.org> Update of bug #13953 (project mc): Status: None => Fixed Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #3: I've just commited a fix: http://cvs.savannah.gnu.org/viewcvs/mc/vfs/extfs.c?root=mc&sortby=date&r2=1.125&r1=1.124&diff_format=u The temporary files used to remain only if MC exited before the vfs "garbage collector" kicked in. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 23 15:33:37 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 23 Mar 2006 17:33:37 +0200 Subject: [patch #4991] add .ipk extension to mc.ext Message-ID: <20060323-173337.sv36205.23406@savannah.gnu.org> URL: Summary: add .ipk extension to mc.ext Project: GNU Midnight Commander Submitted by: ptsekov Submitted on: Thu 03/23/06 at 17:33 Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open _______________________________________________________ Details: I found this in the Debian bugreporting system: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=323927 Maybe we should do apply it ? _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 23 18:53:37 2006 From: savannah-bounces at gnu.org (Leonard den Ottolander) Date: Thu, 23 Mar 2006 19:53:37 +0100 Subject: [patch #4991] add .ipk extension to mc.ext In-Reply-To: <20060323-173337.sv36205.23406@savannah.gnu.org> References: <20060323-173337.sv36205.23406@savannah.gnu.org> Message-ID: <20060323-195337.sv26390.31728@savannah.gnu.org> Follow-up Comment #1, patch #4991 (project mc): I have no idea what .ipk files are, but heck, why not ;) . _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From andy at pylesos.interdon.net Fri Mar 24 08:59:52 2006 From: andy at pylesos.interdon.net (Andy Shevchenko) Date: Fri, 24 Mar 2006 10:59:52 +0200 Subject: F10 issue & special terminal case Message-ID: <4423B508.6030907@pylesos.interdon.net> Hi, All! I use PocketPC and PocketPuTTY ssh client. My PC resolution is 240x320 (qVGA format). I try to use mc under that client. MC window is cut by F6 (in functional menu) and I can't quit from MC due to absense of corresponding menu item. My proposition is to add 'Quit' menu item to the main submenu 'File'. P.S. Functional keys are not working in my case or I do not know how to input their by standart Pocket kbd. -- With best regards, Andy Shevchenko. mailto: andy at smile.org.ua From ptsekov at gmx.net Fri Mar 24 09:24:20 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 24 Mar 2006 10:24:20 +0100 (MET) Subject: F10 issue & special terminal case References: <4423B508.6030907@pylesos.interdon.net> Message-ID: <19267.1143192260@www090.gmx.net> > I use PocketPC and PocketPuTTY ssh client. My PC resolution is 240x320 > (qVGA format). I try to use mc under that client. > MC window is cut by F6 (in functional menu) and I can't quit from MC due > to absense of corresponding menu item. I had plans to make the menu scrollable in the past but no time to actually implement it. Once I get more free time I'll try to implement it. > My proposition is to add 'Quit' menu item to the main submenu 'File'. No. This is a corner case and we are not going to change MC just because of it. > P.S. Functional keys are not working in my case or I do not know how to > input their by standart Pocket kbd. You should input ESC 0 - this is threated as F10 by MC. I.e. hit the esc key and then 0. -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer From ptsekov at gmx.net Fri Mar 24 13:44:07 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 24 Mar 2006 14:44:07 +0100 (MET) Subject: Fwd: Re: F10 issue & special terminal case References: <4423CDBA.7060507@asplinux.ru> Message-ID: <6555.1143207847@www022.gmx.net> PocketPutty should have means for inserting ESC and maybe even functional keys. I remember that when I used putty for Symbian on my Nokia 6600 i saw something like that. In any case you can always type "exit" in the command prompt to exit MC. Scrollable menus would be the best solution to your problem but it will take some time to implement. --- Weitergeleitete Nachricht --- Von: Andy Shevchenko An: Pavel Tsekov Betreff: Re: F10 issue & special terminal case Datum: Fri, 24 Mar 2006 12:45:14 +0200 Pavel Tsekov ??????????: >>My proposition is to add 'Quit' menu item to the main submenu 'File'. > No. This is a corner case and we are not going to change MC just because of > it. But native editor has it. (According to 'Save' button may be good solution to equalize 'Quit' as well?) >>P.S. Functional keys are not working in my case or I do not know how to >>input their by standart Pocket kbd. > You should input ESC 0 - this is threated as F10 by MC. I.e. hit the esc key > and then 0. Pocket kbd has no ESC. I try to Ctrl + [ + 0 and no effect was received. -- With best regards, Andy Shevchenko. mailto: andriy at asplinux.ru -- "Feel free" mit GMX FreeMail! Monat f?r Monat 10 FreeSMS inklusive! http://www.gmx.net From savannah-bounces at gnu.org Fri Mar 24 14:53:26 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Fri, 24 Mar 2006 16:53:26 +0200 Subject: [bug #16176] MC incorrectly completes directories with spaces Message-ID: <20060324-165326.sv36205.50121@savannah.gnu.org> URL: Summary: MC incorrectly completes directories with spaces Project: GNU Midnight Commander Submitted by: ptsekov Submitted on: Fri 03/24/06 at 16:53 Category: Core Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: All versions Platform Version: All _______________________________________________________ Details: This bugreport is based on information found it the Debian bug reporting system: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=326047 I confirmed that the bug exists and needs to be fixed. It is the following code from complete_engine () that causes the problem: if (!in->completions){ end = in->point; for (start = end ? end - 1 : 0; start > -1; start--) if (strchr (" \t;|<>", in->buffer [start])) break; if (start < end) start++; in->completions = try_complete (in->buffer, &start, &end, in->completion_flags); } _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From weigelt at metux.de Sat Mar 25 20:12:30 2006 From: weigelt at metux.de (Enrico 'nekrad' Weigelt) Date: Sat, 25 Mar 2006 21:12:30 +0100 Subject: [article] trimming down autoconf's configure scripts by using pkg-config Message-ID: <200603252012.k2PKCUSr003292@metux.de> Hi folks, here's a little article I wrote about an approach for encapsulating platform dependent stdc-lib fixes (ie. some platforms have broken string handling, etc) behind pkg-config. It is mostly directed on autoconf (It is the one I have most of my daily trouble with), but of course the approach works with other buildsystems, even plain make, too. The permanent URL of the article: * http://www.metux.de/articles/coding/trimming-down-autoconf-with-pkg-config I'm also currently working on concrete wrapper packages: * http://wiki.metux.de/public/OSS_QM_Taskforce/projects/stdc-pkgconfig Comments and suggestions please to the Maillist: oss-qm-discuss at metux.de Thanks. -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: info at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- From leonard at den.ottolander.nl Sun Mar 26 21:42:41 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Sun, 26 Mar 2006 23:42:41 +0200 Subject: [PATCH] Re: Segfault on loading of non existent syntax file In-Reply-To: <1138908815.2624.6.camel@athlon> References: <1138908815.2624.6.camel@athlon> Message-ID: <1143409362.2589.7.camel@athlon> Hi, On Thu, 2006-02-02 at 20:33 +0100, Leonard den Ottolander wrote: > Ran mc from a temporary build dir and copied Syntax to ~/.mc/cedit/ . > Tried editing a file and saw a segfault when the non existent syntax > file is attempted to be loaded. > > #0 edit_get_rule (edit=0x92e8dc0, byte_index=-1) at syntax.c:285 > #1 0x080a4161 in edit_free_syntax_rules (edit=0x92e8dc0) at > syntax.c:977 A fix is attached. When edit_load_syntax() fails on Syntax because the target syntax file is missing there are no syntax rules to be freed, just an uninitialized rules block. That block needs to be (freed and) set to NULL or the editor will attempt to load the block as if it were valid rules and still crash. Leonard. -- mount -t life -o ro /dev/dna /genetic/research -------------- next part -------------- A non-text attachment was scrubbed... Name: syntax.c.nonexistent.patch Type: text/x-patch Size: 1393 bytes Desc: not available URL: From ptsekov at gmx.net Mon Mar 27 09:08:58 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Mon, 27 Mar 2006 11:08:58 +0200 (MEST) Subject: [PATCH] Re: Segfault on loading of non existent syntax file References: <1143409362.2589.7.camel@athlon> Message-ID: <23843.1143450538@www018.gmx.net> > On Thu, 2006-02-02 at 20:33 +0100, Leonard den Ottolander wrote: > > Ran mc from a temporary build dir and copied Syntax to ~/.mc/cedit/ . > > Tried editing a file and saw a segfault when the non existent syntax > > file is attempted to be loaded. > > > > #0 edit_get_rule (edit=0x92e8dc0, byte_index=-1) at syntax.c:285 > > #1 0x080a4161 in edit_free_syntax_rules (edit=0x92e8dc0) at > > syntax.c:977 > > A fix is attached. When edit_load_syntax() fails on Syntax because the > target syntax file is missing there are no syntax rules to be freed, > just an uninitialized rules block. That block needs to be (freed and) > set to NULL or the editor will attempt to load the block as if it were > valid rules and still crash. How about the attached fix ? -- "Feel free" mit GMX FreeMail! Monat f?r Monat 10 FreeSMS inklusive! http://www.gmx.net -------------- next part -------------- A non-text attachment was scrubbed... Name: syntax-missing-file-fix.patch Type: application/octet-stream Size: 776 bytes Desc: not available URL: From leonard at den.ottolander.nl Mon Mar 27 19:57:56 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Mon, 27 Mar 2006 21:57:56 +0200 Subject: [PATCH] Re: Segfault on loading of non existent syntax file In-Reply-To: <23843.1143450538@www018.gmx.net> References: <1143409362.2589.7.camel@athlon> <23843.1143450538@www018.gmx.net> Message-ID: <1143489476.2537.2.camel@athlon> Hi Pavel, On Mon, 2006-03-27 at 11:08 +0200, Pavel Tsekov wrote: > How about the attached fix ? I assume g_malloc0 initializes edit->rules with zeros? This indeed fixes the crash, but doesn't this cause a memory leak? Or is that memory freed elsewhere? Leonard. -- mount -t life -o ro /dev/dna /genetic/research From leonard at den.ottolander.nl Mon Mar 27 20:12:48 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Mon, 27 Mar 2006 22:12:48 +0200 Subject: [PATCH] Re: Segfault on loading of non existent syntax file In-Reply-To: <1143489476.2537.2.camel@athlon> References: <1143409362.2589.7.camel@athlon> <23843.1143450538@www018.gmx.net> <1143489476.2537.2.camel@athlon> Message-ID: <1143490368.2537.9.camel@athlon> Hi Pavel, On Mon, 2006-03-27 at 21:57 +0200, Leonard den Ottolander wrote: > doesn't this cause a memory leak? Or is that memory freed > elsewhere? Last statement in the skipped edit_free_syntax_rules() is a syntax_g_free(edit->rules). I guess we need a free. The zeroing by g_malloc0 only obscures possible code issues so I'd vote against it. I'll use a syntax_g_free instead of a g_free in my patch. Plus I'll have to check how "deeper" includes behave. Leonard. -- mount -t life -o ro /dev/dna /genetic/research From nerijus at users.sourceforge.net Mon Mar 27 21:18:06 2006 From: nerijus at users.sourceforge.net (Nerijus Baliunas) Date: Tue, 28 Mar 2006 00:18:06 +0300 Subject: selecting text References: <1104939486.3694.60.camel@obelix.redhat.usu> Message-ID: <20060327211935.08415BB56@mx.dtiltas.lt> Hello, Selecting text in either viewer or editor does not detect line endings, and there are a lot of spaces when I paste. mc from FC5, mc-4.6.1a-10. Regards, Nerijus From nerijus at users.sourceforge.net Mon Mar 27 21:21:55 2006 From: nerijus at users.sourceforge.net (Nerijus Baliunas) Date: Tue, 28 Mar 2006 00:21:55 +0300 Subject: find in viewer References: <1104939486.3694.60.camel@obelix.redhat.usu> Message-ID: <20060327212935.F3B7FBAD0@mx.dtiltas.lt> Hello, Find in viewer does not remember its last search string: F3, F7, enter some text, Enter, F10. F3, F7 - search string field is empty. It used to remember earlier, and it doesn't happen with editor (editor remembers search string). mc-4.6.1a-10 from FC5. Regards, Nerijus From ptsekov at gmx.net Tue Mar 28 07:54:41 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Tue, 28 Mar 2006 09:54:41 +0200 (MEST) Subject: [PATCH] Re: Segfault on loading of non existent syntax file References: <1143489476.2537.2.camel@athlon> Message-ID: <10103.1143532481@www082.gmx.net> > On Mon, 2006-03-27 at 11:08 +0200, Pavel Tsekov wrote: > > How about the attached fix ? > > I assume g_malloc0 initializes edit->rules with zeros? This indeed fixes > the crash, but doesn't this cause a memory leak? Or is that memory freed > elsewhere? In edit_read_syntax_rules () after the big "for" block: if (!edit->rules[0]) syntax_g_free (edit->rules); -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer From ptsekov at gmx.net Tue Mar 28 07:58:39 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Tue, 28 Mar 2006 09:58:39 +0200 (MEST) Subject: [PATCH] Re: Segfault on loading of non existent syntax file References: <1143490368.2537.9.camel@athlon> Message-ID: <25079.1143532719@www082.gmx.net> > On Mon, 2006-03-27 at 21:57 +0200, Leonard den Ottolander wrote: > > doesn't this cause a memory leak? Or is that memory freed > > elsewhere? > > Last statement in the skipped edit_free_syntax_rules() is a > syntax_g_free(edit->rules). I guess we need a free. You guess .. I guess you should stop guessing and start reading code . > The zeroing by g_malloc0 only obscures possible code issues so I'd vote > against it. Yeah ? And your patch does not obfuscate the matter even more by "fixing" the problem in a place which has nothing to do with this matter ? -- Echte DSL-Flatrate dauerhaft f?r 0,- Euro*! "Feel free" mit GMX DSL! http://www.gmx.net/de/go/dsl From leonard at den.ottolander.nl Tue Mar 28 20:00:55 2006 From: leonard at den.ottolander.nl (Leonard den Ottolander) Date: Tue, 28 Mar 2006 22:00:55 +0200 Subject: [PATCH] Re: Segfault on loading of non existent syntax file In-Reply-To: <25079.1143532719@www082.gmx.net> References: <1143490368.2537.9.camel@athlon> <25079.1143532719@www082.gmx.net> Message-ID: <1143576056.2472.11.camel@athlon> Pavel, On Tue, 2006-03-28 at 09:58 +0200, Pavel Tsekov wrote: > You guess .. I guess you should stop guessing and start reading code . What a prick you are. It's very difficult to have a constructive discussion with somebody who is constantly trying to put down the efforts of others >:-( . Leonard. -- mount -t life -o ro /dev/dna /genetic/research From savannah-bounces at gnu.org Wed Mar 29 11:45:35 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 29 Mar 2006 14:45:35 +0300 Subject: [bug #16213] Find in viewer does not remember its last search string Message-ID: <20060329-144535.sv36205.28243@savannah.gnu.org> URL: Summary: Find in viewer does not remember its last search string Project: GNU Midnight Commander Submitted by: ptsekov Submitted on: Wed 03/29/06 at 14:45 Category: Viewer Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: current (CVS or snapshot) Platform Version: All _______________________________________________________ Details: >From Nerijus Baliunas: =========================================================== Hello, Find in viewer does not remember its last search string: F3, F7, enter some text, Enter, F10. F3, F7 - search string field is empty. It used to remember earlier, and it doesn't happen with editor (editor remembers search string). mc-4.6.1a-10 from FC5. Regards, Nerijus =========================================================== _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 29 12:54:14 2006 From: savannah-bounces at gnu.org (Roland Eggner) Date: Wed, 29 Mar 2006 12:54:14 +0000 Subject: [bug #13729] ctrl- hotlist key won't work under tty In-Reply-To: <20050921-191941.sv41304.55983@savannah.gnu.org> References: <20050711-160003.sv41304.40264@savannah.gnu.org> <20050921-191941.sv41304.55983@savannah.gnu.org> Message-ID: <20060329-125413.sv48204.61253@savannah.gnu.org> Follow-up Comment #2, bug #13729 (project mc): I found a partial solution: Ctrl+4 (left ctrl key + "4" on main part of keyboard) brings mc hotlist, IF running in KDE console. Works with my Notebook Toshiba Satellite 3000-514 and this versions: SuSE-8.2/KDE-3.1.1/mc-4.6.0-336, and also Debian-etch/KDE-3.5.1/mc-4.6.1-1. If it works on other machines too: should be added to help files. More satisfactory would be an additional keybinding - I suppose ctrl+H - that works with german keyboard layout outside of X, too. Until now, outside of X I must use menu entry, have no keybinding for accessing the hotlist. Only "add to hotlist" Ctrl-X H works. _______________________________________________________ Reply to this item at: _______________________________________________ Nachricht geschickt von/durch Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Wed Mar 29 15:07:47 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Wed, 29 Mar 2006 18:07:47 +0300 Subject: [bug #16216] smbfs performance suffers badly if no username is specified in the URL Message-ID: <20060329-180747.sv36205.14225@savannah.gnu.org> URL: Summary: smbfs performance suffers badly if no username is specified in the URL Project: GNU Midnight Commander Submitted by: ptsekov Submitted on: Wed 03/29/06 at 18:07 Category: VFS Severity: 3 - Normal Status: None Privacy: Public Assigned to: None Open/Closed: Open Release: current (CVS or snapshot) Platform Version: All _______________________________________________________ Details: 1) From the Left or Right menu select SMB Link 2) Type the hostname of a remote samba server 3) \\Password for \\xxx.xxx.xxx.xxx\IPC$ dialog appears. In the Username field type GUEST 4) Navigate to a share and press Enter. Notice how long it takes to load the listing 5) Go to a .tar.gz file and hit Enter -> MC will crash This problem is caused by the fact that smbfs uses a pool of active connections which are uniquely identified by their hostname, username and sharename. When no user is specified in the url, but in the "Password for" dialog and this name is different from the current login name, smbfs thinks that we are trying to connect to the remote machine with the current login name. This confuses smbfs and it doesn't notice that there is a valid connection which can be reused - the result is that smbfs opens a new connection each time it needs to issue a command to the samba server. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 30 09:10:24 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 30 Mar 2006 12:10:24 +0300 Subject: [bug #16216] smbfs performance suffers badly if no username is specified in the URL In-Reply-To: <20060329-180747.sv36205.14225@savannah.gnu.org> References: <20060329-180747.sv36205.14225@savannah.gnu.org> Message-ID: <20060330-121024.sv36205.94831@savannah.gnu.org> Follow-up Comment #1, bug #16216 (project mc): I am attaching a patch. _______________________________________________________ Additional Item Attachment: File name: mc-smbfs-dont-trash-connections.patch Size:5 KB _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From savannah-bounces at gnu.org Thu Mar 30 12:57:53 2006 From: savannah-bounces at gnu.org (Pavel Tsekov) Date: Thu, 30 Mar 2006 15:57:53 +0300 Subject: [bug #13101] Moving/copying single files to FTP VFS In-Reply-To: <20060323-143747.sv36205.37888@savannah.gnu.org> References: <20050516-171400.sv14402.43576@savannah.gnu.org> <20060217-115635.sv36205.97285@savannah.gnu.org> <20060217-151856.sv36205.26217@savannah.gnu.org> <20060221-171014.sv36205.3953@savannah.gnu.org> <20060221-171119.sv36205.41580@savannah.gnu.org> <20060223-080037.sv14402.14960@savannah.gnu.org> <20060223-102448.sv36205.2746@savannah.gnu.org> <20060224-073135.sv14402.11175@savannah.gnu.org> <20060224-074709.sv14402.57728@savannah.gnu.org> <20060306-103511.sv36205.68323@savannah.gnu.org> <20060306-103624.sv36205.54849@savannah.gnu.org> <20060308-170047.sv36205.6244@savannah.gnu.org> <20060308-170204.sv36205.85604@savannah.gnu.org> <20060309-011502.sv14402.28237@savannah.gnu.org> <20060309-104855.sv36205.44385@savannah.gnu.org> <20060323-143747.sv36205.37888@savannah.gnu.org> Message-ID: <20060330-155753.sv36205.96286@savannah.gnu.org> Update of bug #13101 (project mc): Status: Fixed => Postponed Open/Closed: Closed => Open _______________________________________________________ Follow-up Comment #14: Reopening this one. I'll revert the patch since it breaks fish. Once I fix this breakage I'll commit it again. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From ptsekov at gmx.net Thu Mar 30 14:45:12 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Thu, 30 Mar 2006 16:45:12 +0200 (MEST) Subject: Fix for slow fish uploads Message-ID: <16096.1143729912@www018.gmx.net> Hello Dmitry, I've applied the patch you posted in December, 2004: http://mail.gnome.org/archives/mc-devel/2004-December/msg00035.html Thanks! Pavel "Prick" Tsekov -- Analog-/ISDN-Nutzer sparen mit GMX SmartSurfer bis zu 70%! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer From ptsekov at gmx.net Fri Mar 31 14:39:37 2006 From: ptsekov at gmx.net (Pavel Tsekov) Date: Fri, 31 Mar 2006 16:39:37 +0200 (MEST) Subject: Fix for slow fish uploads References: <16096.1143729912@www018.gmx.net> Message-ID: <11793.1143815977@www030.gmx.net> Hello, > Hello Dmitry, > > I've applied the patch you posted in December, 2004: > > http://mail.gnome.org/archives/mc-devel/2004-December/msg00035.html After applying this patch Dmitry notified me that he updated the original patch (posted in December, 2004) since it was found to be not reliable enough in certain scenarios - you can find more about that here: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186456 I've applied the patch Dmitry posted in the RedHat's bugzilla to our cvs too. Thanks! Pavel "Prick" Tsekov -- Analog-/ISDN-Nutzer sparen mit GMX SmartSurfer bis zu 70%! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer