Fix for password-protected .rar files

Denis Vlasenko vda.linux at googlemail.com
Tue Jul 25 13:36:26 UTC 2006


On Tuesday 25 July 2006 09:44, Pavel Tsekov wrote:
> Hello Denis,
> 
> On Mon, 24 Jul 2006, Denis Vlasenko wrote:
> 
> >> The patch includes random quoting of shell variables as well
> >> as formatting fixes  - please submit a proper patch which does
> >> only what it advertises.
> >
> > Ok, the attached patch quotes some environment variables.
> >
> > vfs/extfs/* scripts seem to presume that there are no spaces
> > in filenames. Yes, we typically do not expect $TMPDIR to contain spaces,
> > but if it will contain them on some strange system, then what?
> > Is cd $TMPDIR ok? No! cd "$TMPDIR"!
> >
> > The attached patch fixes these.
> 
> The attached patch again includes indentation-only fixes (rpm, trpm, uar, 
> maybe others). Please, submit a proper patch.

Patch is fixed and split up into quoting fixes and indent fixes.
See attached.

Please apply.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extfs.diff
Type: text/x-diff
Size: 2611 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20060725/a18915f0/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indent.diff
Type: text/x-diff
Size: 1654 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20060725/a18915f0/attachment-0001.diff>


More information about the mc-devel mailing list