[bug #4327] ftpfs confused by certain directory names

Leonard den Ottolander leonard at den.ottolander.nl
Sat Jan 28 14:17:51 UTC 2006


Hi Roland,

On Sat, 2006-01-28 at 14:58 +0100, Roland Illig wrote:
> Just another idea: We could use the NLST command to only list the names 
> of the files and later check for them in the LIST command. This would 
> make it possible to deal with all but filenames containing "\r\n".
> 
> This task is non-trivial to get optimal, but we could at least try ...

I'm not sure if it is worth the effort at this time. With the assumption
that the date field contains 3 elements we can already establish where
the file name starts.

Afaict there are no practical cases where vfs_parse_filedate() needs to
parse dates with 4 elements. If there were we either have to add an
option to vfs_parse_filedate() to distinguish between 3 or 4 element
dates or we should write an extra function vfs_parse_filedate4().

No need to add the extra overhead of an extra command. Also isn't NLST
an FTP specific command? The function is called vfs_parse_filedate() not
ftp_parse_filedate() as it is supposed to be usable by other vfses as
well.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





More information about the mc-devel mailing list