subshell output swallowed (patch)

Pavel Tsekov ptsekov at gmx.net
Tue Jan 24 17:05:41 UTC 2006


> --- Ursprüngliche Nachricht ---
> Von: Egmont Koblinger
> Betreff: Re: subshell output swallowed (patch)
> Datum: Tue, 24 Jan 2006 17:16:34 +0100
> 
> Hi,
> 
> > Your first post implied that it was SIGCHLD
> > interrupting a write() call which is reponsible for the broken ouput of
> > `ls'.
> 
> I'm not 100% sure that sigchld is the _direct_ cause of the short write.
> Maybe sigchld causes something else which in turn leads to a short write.
> 
> > What worries me is that you don't understand well what is the cause of
> the
> > problem that you see.
> 
> Hey! When I first saw this bug, I didn't even know whether it was a bug in
> gnome-terminal (where I had previously fixed several similar screen
> corruption bugs), a bug in ls, or in mc. Or maybe somewhere else. But in
> less than half hour I was able to locate this heuristical bug, I was able
> to
> roughly explain what happens there, and finally I was able to create a fix
> (or workaround).

I can point you to at least one similiar case in which the supposed fix did
fix the symptom but not the cause. The patch in question fixed the subshell
behaviour only when bash was used. With tcsh the same fix caused MC to hang.
I was able to predict that the patch is not good by just reading the patch.

I want to understand the problem or at least ot see a plausible explanation
as to what's causing it. If it is more than a short write I don't want your
patch to hide the real cause. Otherwise your patch is OK.

-- 
DSL-Aktion wegen großer Nachfrage bis 28.2.2006 verlängert:
GMX DSL-Flatrate 1 Jahr kostenlos* http://www.gmx.net/de/go/dsl



More information about the mc-devel mailing list