Patch for cmd.c

Pavel Shirshov (pchel) me at pavelsh.pp.ru
Mon Oct 25 09:36:18 UTC 2004


Hello Andrew,

Monday, October 25, 2004, 3:25:24 PM, you wrote:

AVS> Hi,
>> 
>> this patch fixes rare and almost impossible off-by-one.
>> If user input is empty (""), these lines can do very bad thing:
>> 
>>     if (reg_exp_t [strlen(reg_exp_t) - 1] == PATH_SEP){
>>         dirflag = 1;
>>         reg_exp_t [strlen(reg_exp_t) - 1] = 0;
>>     }
>> 
>> It is almoust impossible to meet PATH_SEP before '\0', but sometimes it happens.

AVS> Patch attached, sorry for inconvenience.

Committed. Thx


-- 
Best regards,
 Pavel                            mailto:me at pavelsh.pp.ru




More information about the mc-devel mailing list