patch: mcview with growing buffers

Roland Illig roland.illig at gmx.de
Fri Oct 22 13:21:05 UTC 2004


Hi,

this patch is quite complex. It fixes these issues:

- WView contained a struct stat that was only partly used (and mostly 
abused for _not_ storing file information).
- Error checking using the growing buffer has been added.
- Some variables need an adjustment function called after they are 
assigned a new value. This is explicitly documented.
- Some variables have been renamed. For example, char *data is now 
accompanied by size_t datasize. A similar change has been applied to the 
mmap functions: The variable bytes_read has been used inconsistently and 
has been replaced by mmappedsize.
- The function get_byte has become much simpler after factoring out the 
growing buffer handling into a separate function.

Please fill out:
[ ] ok to commit
[ ] needs review
[ ] rejected

Roland

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mc_src_view.c-error-handling.patch
Type: text/x-patch
Size: 13420 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20041022/4223d11e/attachment.bin>


More information about the mc-devel mailing list