extfs shell script fixes (audio.in)

Leonard den Ottolander leonard at den.ottolander.nl
Sun Oct 17 17:57:05 UTC 2004


Hi,

I wrote:
> Quoting $1 is unnecessary here as no shell is spawned. This hunk can
> thus be dropped.

As Roland pointed out to me although the quoting is not necessary from a
security standpoint it saves special characters and spaces.
Reintroduced. See attached patch.

> This makes me wonder if the quoting of $f and the use of SEDCMD in
> extfs/rpm mcrpmfs_copyout() and mcrpmfs_run aren't redundant either.

...

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research

-------------- next part --------------
A non-text attachment was scrubbed...
Name: audio.in.diff
Type: text/x-patch
Size: 1661 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20041017/9497c527/attachment.bin>


More information about the mc-devel mailing list