extfs shell script fixes (audio.in)

[Leonard den Ottolander]

Hi,

Some remarks on the SUSE extfs shell fixes regarding audio.in:

@@ -15,7 +15,7 @@
-    cdparanoia -Q -d $1 2>&1 | grep '^[ 0-9][ 0-9][ 0-9]\.' | while
true
+    cdparanoia -Q -d "$1" 2>&1 | grep '^[ 0-9][ 0-9][ 0-9]\.' | while
true

Quoting $1 is unnecessary here as no shell is spawned. This hunk can
thus be dropped.

Same is true for
-        cdparanoia -q -d $1 $TRACK $3 >/dev/null
+        cdparanoia -q -d "$1" $TRACK "$3" >/dev/null
in @@ -28,15 +28,15 @@

@@ -48,7 +48,7 @@
-  list) audiofs_list $BASE; exit 0;;
-  copyout) audiofs_copyout $BASE $3 $4; exit 0;;
+  list) audiofs_list "$BASE"; exit 0;;
+  copyout) audiofs_copyout "$BASE" "$3" "$4"; exit 0;;

$BASE, $3 and $4 don't need to be quoted either.

This makes me wonder if the quoting of $f and the use of SEDCMD in
extfs/rpm mcrpmfs_copyout() and mcrpmfs_run aren't redundant either. Any
thoughts?

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research