superfluous updating in file move dialog
Miven Dooligan
mdooligan at gawab.com
Sat Oct 2 13:03:33 UTC 2004
in src/file.c:move_file_file() calls progress_update_one() when it's
already called copy_file_file() which also calls progress_update_one()
which screws up the progress_count in the visible dialog. It does
progress_count++ twice for every file (as well as progress_bytes+=add).
This has been bugging me for quite a while, but I finally got around to
scratching at the problem.
--- ../../mc-cvs-031122/src/file.c Mon Oct 27 09:36:19 2003
+++ file.c Sun Jun 6 14:28:44 2004
@@ -1184,12 +1184,12 @@
return return_status;
}
- if (return_status == FILE_CONT)
- return_status = progress_update_one (ctx,
- progress_count,
- progress_bytes,
- src_stats.st_size, 1);
-
+// if (return_status == FILE_CONT)
+// return_status = progress_update_one (ctx,
+// progress_count,
+// progress_bytes,
+// src_stats.st_size, 1);
+//
return return_status;
}
seems to work as a temporary fix.
Comments?
More information about the mc-devel
mailing list