prompt, spaces, `cd' and system commands..

Leonard den Ottolander leonard at den.ottolander.nl
Sat Nov 27 13:07:25 UTC 2004


Hi q#,

On Sat, 2004-11-27 at 03:06, q# wrote:
> This patch fix this issue, but please _double check_ this patch.
> Comments are _very_ welcome.

Although I haven't looked very closely at your patch there is one thing
that catches the eye. You rename variables, thus introducing a lot of
bloat in the patch. Why rename len to sn, and cmd to tmp? Leaving these
names intact and introduce new names for the new variables. That will
take of half the size of your patch and makes it easier to understand
what you actually try to achieve.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





More information about the mc-devel mailing list