strippwd patch against CVS20041108

Jindrich Novy jnovy at redhat.com
Wed Nov 10 17:07:08 UTC 2004


Hello Pavel, Leonard,

On Wed, 2004-11-10 at 17:15, Jindrich Novy wrote:
> Hello Pavel,
> 
> On Tue, 2004-11-09 at 20:10, me at pavelsh.pp.ru wrote:
> > Hello Leonard,
> > 
> > Tuesday, November 9, 2004, 7:13:26 PM, you wrote:
> > 
> > LdO> These are the hunks of the strippwd patch that have not yet been
> > LdO> committed.
> > 
> >      Committed with my fixes.
> 
> Note that your "fix" actually reintroduced the bug I've been trying to
> fix. So the path is now cut out again.

I checked out the latest CVS snapshot and see you fixed it. Thanks for
it, because moving the if (dir) condition before if (at) should fix the
path bug.

Anyway I don't agree with the style of the fix. The only different
functionality you did is that you seek for '@' backwards (strrchr) and
you need to zero out one character in p, which is also argument of the
function and the return it back to PATH_SEP.

The attached patch is doing the same thing, but without the ugly zero
and '/' return style. Note that the only change to do is to substitute
memchr with memrchr in my original patch.

Patch to the latest CVS snapshot is attached.

-- 
Jindrich Novy <jnovy at redhat.com>, http://people.redhat.com/jnovy/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mc-4.6.1-20041110-spw.patch
Type: text/x-patch
Size: 855 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20041110/5252aa09/attachment.bin>


More information about the mc-devel mailing list