strip_passwd partial commit
Jindrich Novy
jnovy at redhat.com
Tue Nov 9 10:23:47 UTC 2004
Hello Pavel,
On Tue, 2004-11-09 at 07:22, Pavel Shirshov (pchel) wrote:
> I got an output
> -----------------------------------------------------
> genie# ./mc
> pavelsh at test.ru:pass at test.your.domain/path/to/file
> pavelsh at test.ru@test.your.domain
> pavelsh at test.ru:pass at test.your.domain/path/to/file
> -------------------------
> pavelsh:pass at test.your.domain/path/to/file
> pavelsh at test.your.domain
> pavelsh at test.your.domain/path/to/file
> -------------------------
> pavelsh at test.ru:pass at test.your.domain/
> pavelsh at test.ru@test.your.domain
> pavelsh at test.ru:pass at test.your.domain/
> -------------------------
> pavelsh at test.ru:pass at test.your.domain/path/to/file/
> pavelsh at test.ru@test.your.domain
> pavelsh at test.ru:pass at test.your.domain/path/to/file/
> -------------------------
Please note that the test case is valid only for URL present in string
txt2:
> pavelsh:pass at test.your.domain/path/to/file
> pavelsh at test.your.domain
> pavelsh at test.your.domain/path/to/file
where the strip_password_new() behaves as it should (last line).
The rest of testing URLs are malformed, because they're not RFC-1738
compliant. So they *shouldn't* be used as URLs. Please see
http://www.faqs.org/rfcs/rfc1738.html section 3.1.
However, from the test case txt2 it's apparent the bug in the original
strip_password().
greetings,
Jindrich
--
Jindrich Novy <jnovy at redhat.com>, http://people.redhat.com/jnovy/
More information about the mc-devel
mailing list