strip_passwd partial commit

Pavel Shirshov (pchel) me at pavelsh.pp.ru
Thu Nov 4 05:47:24 UTC 2004


Hello Leonard,

Thursday, November 4, 2004, 1:53:41 AM, you wrote:

LdO> Just read on IRC that you did a partial commit of the strip_passwd
LdO> patch. Could you please explain what parts you didn't commit (yet) and
LdO> for what reason? Then people can explain them.

     Ok.

     I didn't patch:

       hotlist.c - need some testing and improvements. I want to save
       full url (with password), but display title without password.
       
       util.c(strip_password()) - need some additional testing. For
       example around:
-        at = strrchr (p, '@');
+       at = memchr (p, '@', host_len);

       It's not equal operations.

-- 
Best regards,
 Pavel                            mailto:me at pavelsh.pp.ru




More information about the mc-devel mailing list