Status of FTP password hiding patches

Jindrich Novy jnovy at redhat.com
Wed Nov 3 16:21:34 UTC 2004


Hello Pavel, Leonard,

On Wed, 2004-11-03 at 16:54, Leonard den Ottolander wrote:
> Hello Pavel,
> 
> On Wed, 2004-11-03 at 16:41, Pavel Shirshov (pchel) wrote:
> > $ patch -p2 < mc-CVS-strippwd.patch
> > ......
> > Patching file filegui.c using Plan A...
> > Hunk #1 failed at 68.
> 
> Trivial fix. tty.h is no longer included. Insert after #include key.h.
> 
> > Hunk #8 failed at 907.
> 
> So the freeing of def_text was dropped, as this is a function parameter.
> Reintroduce the brackets and add the g_free(def_text_secure) in this
> block and right below it. Rather trivial fix as well.
> 
> > Patching file hotlist.c using Plan A...
> > Hunk #4 failed at 1008.
> 
> Little mistake from Jindrich. UTF-8 patched mc uses mbstrlen, vanilla
> CVS strlen. Insert by hand in the same place. Just removing "mb" from
> mbstrlen might do the trick.

Exactly as Leonard have said. Here comes the fixed patch applicable to
the vanilla CVS.

Jindrich

-- 
Jindrich Novy <jnovy at redhat.com>, http://people.redhat.com/jnovy/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mc-CVS-strippwd.patch
Type: text/x-patch
Size: 10802 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20041103/c45187f0/attachment.bin>


More information about the mc-devel mailing list