deba.in.diff
Leonard den Ottolander
leonard at den.ottolander.nl
Thu Aug 19 09:10:02 UTC 2004
Hi,
Since ls() is not used in deba.in and ls() is the only function calling
bt(), ft() and fm() all four functions are redundant here.
Also 3 occurrences of shell invocations that I escape using
map(s/([^\w\/.+-])/\\$1/g, @_). Note that this escapes all parameters,
although there is only one vulnerable in each function.
Instead of the used regular expression "quotemeta" could be used
instead. Another possibility is only to escape the vulnerable parameter.
Leonard.
--
mount -t life -o ro /dev/dna /genetic/research
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deba.in.diff
Type: text/x-patch
Size: 3122 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20040819/60aee426/attachment.bin>
More information about the mc-devel
mailing list