Just got mc-4.6.0-pre1

[Miven Dooligan]

Pavel Roskin wrote:

> Hello!
>
>> 'make install' didn't do vfs directory. I had to cd into it and do
>> 'make' manually. Just missing from the Makefile.
>
>
> I tried and could not reproduce this problem. Please give more details
> about the commands you ran (which arguments to configure, make etc).
> Describe the errors actually reported on the screen, not your
> interpretation. 

I just copied the cvs source into a fresh directory, used this 
 configuration:
Duron750, Mandrake8.2, gcc-2.96,  gnome, sawfish, gnome-terminal, 
$TERM=xterm.

Configuration:

  Source code location:       .
  Compiler:                   gcc
  Compiler flags:             -g -O2 -Wall
  File system:                Midnight Commander Virtual File System
                              tarfs, ftpfs, fish, smbfs
  Screen manager:             SLang with terminfo
  Install console saver:      yes
  Mouse support:              GPM and xterm
  X11 events support:         yes
  Debugger code:             
  With subshell support:      yes
  Internal editor:            yes
  Install path:               /usr/local/bin, /usr/local/lib/mc

and this happened:

make[1]: Entering directory `/usr/src/mc/mc-test/vfs'
source='tcputil.c' object='tcputil.o' libtool=no \
depfile='.deps/tcputil.Po' tmpdepfile='.deps/tcputil.TPo' \
depmode=gcc3 /bin/sh ../config/depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I..   -I.. -Ino/include 
-I/usr/include/glib-1.2 -I/usr/lib/glib/include -DCONFIGDIR=\""/etc"\" 
-g -O2 -Wall -c `test -f 'tcputil.c' || echo './'`tcputil.c
In file included from ../src/tty.h:27,
                 from utilvfs.h:3,
                 from tcputil.c:49:
/usr/include/ncurses/curses.h:434:42: macro "baudrate" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:435:39: macro "beep" passed 1 arguments, 
but takes just 0
/usr/include/ncurses/curses.h:460:42: macro "doupdate" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:465:40: macro "endwin" passed 1 arguments, 
but takes just 0
/usr/include/ncurses/curses.h:469:42: macro "flushinp" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:486:46: macro "initscr" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:528:71: macro "mvprintw" passed 4 
arguments, but takes just 3
/usr/include/ncurses/curses.h:565:40: macro "noecho" passed 1 arguments, 
but takes just 0
/usr/include/ncurses/curses.h:568:39: macro "noraw" passed 1 arguments, 
but takes just 0
/usr/include/ncurses/curses.h:582:37: macro "raw" passed 1 arguments, 
but takes just 0
/usr/include/ncurses/curses.h:584:41: macro "refresh" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:586:49: macro "reset_prog_mode" passed 1 
arguments, but takes just 0
/usr/include/ncurses/curses.h:587:50: macro "reset_shell_mode" passed 1 
arguments, but takes just 0/usr/include/ncurses/curses.h:618:42: macro 
"standend" passed 1 arguments, but takes just 0
/usr/include/ncurses/curses.h:619:45: macro "start_color" passed 1 
arguments, but takes just 0
make[1]: *** [tcputil.o] Error 1
make[1]: Leaving directory `/usr/src/mc/mc-test/vfs'
make: *** [all-recursive] Error 1

It seems #define USE_NCURSES 1 is set if I use --with-ncurses=no or 
--without-ncurses.  
I have to remove any reference to ncurses completely to get it to not 
set USE_NCURSES.  
I think that was the original problem.  When I first got the pre1 
source, I used a
./configure command from 4.5.55 that had -with-<package>=no on some things
because it used to compile a bunch of stuff in that I didn't want, so I 
manually unset them.
./configure --help says that you can use --with-<package>=no or 
--without-<package>.
I don't think I should monkey with the configure scripts, thats DEEP MAGIC.

>> When mc first starts, I always get the user menu (?). Extra keystrokes
>> from somewhere? Anyone else get this?
>
>
> I think you have "Auto menus" enabled in Options->Configuration. This
> option is disabled by default, but maybe you enabled this option in an
> older version with broken "Auto menus" support.

Again, you are correct. I wasn't sure what auto-menus meant, and it never
seemed to do anything.  I'm still not sure what it does.

>
> No. We need a more planned approach here, not a bunch of hacks. 

Yes, the code is well-hacked already isn't it?
The program is great, but the code is a bit spotty and disorganized in 
places,
but DEFINATELY needs to be kept alive. Glad you're in charge.  

>
> I think mc has more than enough hacks, thank you very much!

I agree, and you're welcome :-).
It's so... so... hackable, and a great place to learn what makes a great
C program work..

>If you have any details, please post them.  Maybe what you mean is a
>simple bug that doesn't require rewriting the whole color support :-)
>
Yes, it's a little bug somewhere.  Four lines in menu.c. See attachment.

Cheers.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: menubar.patch.gz
Type: application/gzip
Size: 651 bytes
Desc: not available
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20020918/9e8edfe1/attachment.bin>