mcedit leaks file handler if safe save set
Andrew V. Samoilov
sav at it.efp.com.ua
Sat Dec 22 12:50:10 UTC 2001
Hi, Pavel!
> I don't think this bug is present in 4.5.55. I disabled safe save and
> backups on remote VFS exactly for that reason and you reenabled it after
> the release:
Andrew found this bug exactly in pure mc-4.5.55. If you
find some minutes to think you have to understand this bug is not related to
VFS.
As far as I remember you disabled safe save because you
wrongly guessed rename is not implemented over VFS. And there is no one
word about mc_mkstemps in your messages.
>
> 2001-11-19 Andrew V. Samoilov <kai at cmail.ru>
> ...
> (edit_save_file): Enable safe save and backups on remote VFS.
>
> > * it is used in edit/editcmd.c/edit_save_file() to generate filename
> > for safe save.
> > * without temporary hack below mc leaks file handlers and
> > this/these file(s) cannot be unlinked or executed.
>
> Ok, please feel free to fix your bugs :-)
You are so kindly, but it 100% YOUR BUG. And only a cup of good lipton tea
made me kindly
to you back today. Ok, safe save over VFS should be really disabled for
this reason, but
backup is ok.
> > BTW, Andrew W. Nosenko reported undelfs is not large file compatible.
> > There are atol is used in some places for ino_t.
>
> As far as I understand, ino_t stores the file number on the filesystem. I
> don't understand how it can have anything to do with large file support.
> Please explain.
I have no access to mc sources and no time right now. Some later, ok?
With best wishes,
Andrew.
More information about the mc-devel
mailing list