Double // in codepages list error

[David Martin]

>  Hi, David!
>  
>  > Here's the quick fix using concat_dir_and_file.
>  
>  The problem is not in the error message.  concat_dir_and_file() should be
>  used in load_codepages_list() (it is not used) and the message should be
>  there, because only that function knows what happened, what file it
>  _actually_ tried to open and whether the problem is worth user's
>  attention.

I agree. I did this patch too, but I thought it might not be a good idea to
send it.

>  
>  I understand that my criticism really should be directed at Walery, but
>  I'm asking everybody to clean up the code being modified instead of
piling
>  one "quick fix" onto another.
>  
>  I'm not applying your patch - it cures the symptoms, not the disease.
>  
>  By the way, if you _have_ to introduce a new translatable message please
>  avoid that british "Can't" - write "Cannot" instead.
>  

The line was there before. It wasn't me: Don't blame me.
What about en_GB.po? Once someone complained in the list about it.

...and what about OK and Ok? How do "you" spell it?
(I'm actually Australian but I've lived in Spain since I was 4 :)
English humor, you know!

You made no changes in setup.c so the original message and the "//" 
stay there. Is this the final solution?

Keep in mind when changing charsets.c that the load_codepages_list() has two
"return" (...) and that the message is now displayed both when the file is
missing and when there are no codepages (<= 0).

Just in case it's of any use here's the second patch I made. Someone could
argue not to place GUI in charsets.c and this was the second reason no to
post it yesterday.

*8-) David





_______________________________________________________
¡Tienes cuentas de e-mail GRATIS en Excite España!
A tu disposición en http://correo.excite.es 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: qcharset_err2.diff
URL: <http://lists.midnight-commander.org/pipermail/mc-devel/attachments/20010812/e08d3611/attachment.diff>