New release

Andrew V. Samoilov sav at bcs.zp.ua
Mon Aug 6 15:52:44 UTC 2001


Hi!
Pavel Roskin wrote:
: I believe we should impose "string freeze" right now until the release
: (i.e. stop applying any patches adding new translatable strings), so that
: I can write to gnome-i18n.  Is it Ok?
: 
Some time ago I commited a patch for vfs/smbfs.c with new translatable string:

Index: smbfs.c
===================================================================
RCS file: /home/sav/.cvsroot/mc/vfs/smbfs.c,v
retrieving revision 1.21.2.3
diff -u -p -r1.21.2.3 smbfs.c
--- smbfs.c	3 Aug 2001 13:32:57 -0000	1.21.2.3
+++ smbfs.c	5 Aug 2001 21:14:08 -0000
@@ -1923,15 +1914,17 @@ static int
 smbfs_unlink (vfs *me, char *path)
 {
     smbfs_connection *sc;
-    char *remote_file;
+    char *remote_file, *p;
 
     if ((remote_file = smbfs_get_path (&sc, path)) == 0)
 	return -1;
- 
+
+    p = remote_file;
     convert_path(&remote_file, FALSE);
+    g_free (p);
 
     if (!cli_unlink(sc->cli, remote_file)) {
-        message_3s (1, MSG_ERROR, _(" %s opening remote file %s "), 
+	message_3s (1, MSG_ERROR, _(" %s removing remote file %s "), 
 			cli_errstr(sc->cli), CNV_LANG(remote_file));
 	g_free (remote_file);
 	return -1;

It was incorrect message and as for me it is better to have untranslated
message than wrong translated.

Best regards,
Andrew.




More information about the mc-devel mailing list