From proski at gnu.org Thu Apr 26 23:56:49 2001 From: proski at gnu.org (Pavel Roskin) Date: Thu, 26 Apr 2001 19:56:49 -0400 (EDT) Subject: Fix for hang in search_content() Message-ID: Hello, Andrew! You last patch for find.c does more than the ChangeLog says. This change in search_content() is not described in ChangeLog. - while (1){ - i = read (pipe, &c, 1); - if (i != 1) - break; + + while ((i = read (pipe, &c, 1)) == 0){ If you think it's a formatting change, look again - it's not. Sometimes (too often actually!) read() returns values other than 0 and 1, for example -1. If you want to rewrite this part in a clear, nice way you are welcome to, but for now I'm reverting this part of your patch since it causes a useless loop with 100% CPU load while attempting to search for contents. -- Regards, Pavel Roskin From miguel at ximian.com Fri Apr 27 20:48:55 2001 From: miguel at ximian.com (Miguel de Icaza) Date: 27 Apr 2001 16:48:55 -0400 Subject: testing mc-devel@GNOME.ORG Message-ID: From proski at gnu.org Mon Apr 30 04:32:30 2001 From: proski at gnu.org (Pavel Roskin) Date: Mon, 30 Apr 2001 00:32:30 -0400 (EDT) Subject: testing mc-devel@GNOME.ORG (fwd) Message-ID: Hi, Miguel! The test looks good. Same for mc at gnome.org. I'm a bit worried about using Mailman 2.0beta5 while the stable (and newer) version 2.0.3 is available. On the positive side, it took just minutes for the message to go through the whole chain. -- Regards, Pavel Roskin ---------- Forwarded message ---------- Envelope-to: proski at gnu.org Received: from fencepost.gnu.org [199.232.76.164] by localhost with IMAP (fetchmail-5.6.2) for proski at localhost (single-drop); Fri, 27 Apr 2001 17:01:08 -0400 (EDT) Received: from menu.gnome.org ([209.116.70.71] helo=mail.gnome.org) by fencepost.gnu.org with smtp (Exim 3.16 #1 (Debian)) id 14tFHE-0007ZA-00 for ; Fri, 27 Apr 2001 16:55:44 -0400 Received: from mail.gnome.org (localhost.localdomain [127.0.0.1]) by mail.gnome.org (Postfix) with ESMTP id 271072BD2A; Fri, 27 Apr 2001 16:55:16 -0400 (EDT) Delivered-To: mc-devel at gnome.org Received: from erandi.helixcode.com (erandi.ximian.com [141.154.95.33]) by mail.gnome.org (Postfix) with ESMTP id B49E52BAB8 for ; Fri, 27 Apr 2001 16:50:56 -0400 (EDT) Received: (from miguel at localhost) by erandi.helixcode.com (8.9.3/8.9.3) id QAA11752; Fri, 27 Apr 2001 16:48:55 -0400 To: mc-devel at gnome.org Subject: testing mc-devel at GNOME.ORG From: Miguel de Icaza Date: 27 Apr 2001 16:48:55 -0400 Message-ID: Lines: 0 X-Mailer: Gnus v5.7/Emacs 20.5 Sender: mc-devel-admin at gnome.org Errors-To: mc-devel-admin at gnome.org X-BeenThere: mc-devel at gnome.org X-Loop: mc-devel at gnome.org X-Mailman-Version: 2.0beta5 Precedence: bulk List-Id: _______________________________________________ Mc-devel mailing list Mc-devel at gnome.org http://mail.gnome.org/mailman/listinfo/mc-devel